Skip to content

Conversation

@DamonFool
Copy link
Member

@DamonFool DamonFool commented Aug 24, 2023

JDK-8313530 fixed the release VM build but the debug VM build would still fail.
This patch fix the debug VM build failure.
Thanks.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314951: VM build without C2 still fails after JDK-8313530 (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15419/head:pull/15419
$ git checkout pull/15419

Update a local copy of the PR:
$ git checkout pull/15419
$ git pull https://git.openjdk.org/jdk.git pull/15419/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15419

View PR using the GUI difftool:
$ git pr show -t 15419

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15419.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 24, 2023

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 24, 2023
@openjdk
Copy link

openjdk bot commented Aug 24, 2023

@DamonFool The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels Aug 24, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 24, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 24, 2023

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314951: VM build without C2 still fails after JDK-8313530

Reviewed-by: dnsimon, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 2624324: 8219567: Name of first parameter of RandomAccessFile(String,String) is inconsistent
  • 8e4240c: 8314850: SharedRuntime::handle_wrong_method() gets called too often when resolving Continuation.enter
  • d9fc6b6: 8314759: VirtualThread.parkNanos timeout adjustment when pinned should be replaced
  • acaab6f: 8306040: HttpResponseInputStream.available() returns 1 on empty stream

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 24, 2023
Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@DamonFool
Copy link
Member Author

Thanks @dougxc and @vnkozlov for your review.
/integrate

@openjdk
Copy link

openjdk bot commented Aug 25, 2023

Going to push as commit d024059.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 2624324: 8219567: Name of first parameter of RandomAccessFile(String,String) is inconsistent
  • 8e4240c: 8314850: SharedRuntime::handle_wrong_method() gets called too often when resolving Continuation.enter
  • d9fc6b6: 8314759: VirtualThread.parkNanos timeout adjustment when pinned should be replaced
  • acaab6f: 8306040: HttpResponseInputStream.available() returns 1 on empty stream

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 25, 2023
@openjdk openjdk bot closed this Aug 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 25, 2023
@openjdk
Copy link

openjdk bot commented Aug 25, 2023

@DamonFool Pushed as commit d024059.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants