Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314990: Generational ZGC: Strong OopStorage stats reported as weak roots #15420

Closed
wants to merge 1 commit into from

Conversation

JonasNorlinder
Copy link
Contributor

@JonasNorlinder JonasNorlinder commented Aug 24, 2023

ZOopStorageSetIteratorStrong::apply has incorrect ZRootStatTimerevent. Should record strong roots but are recording weak roots.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314990: Generational ZGC: Strong OopStorage stats reported as weak roots (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15420/head:pull/15420
$ git checkout pull/15420

Update a local copy of the PR:
$ git checkout pull/15420
$ git pull https://git.openjdk.org/jdk.git pull/15420/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15420

View PR using the GUI difftool:
$ git pr show -t 15420

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15420.diff

Webrev

Link to Webrev Comment

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Aug 24, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 24, 2023

Hi @JonasNorlinder, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user JonasNorlinder" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Aug 24, 2023

@JonasNorlinder The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Aug 24, 2023
@bridgekeeper bridgekeeper bot removed the oca Needs verification of OCA signatory status label Aug 24, 2023
@JonasNorlinder JonasNorlinder changed the title Fix ZRootStatTimer event 8314990: Generational ZGC: Strong OopStorage stats reported as weak roots Aug 25, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 25, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 25, 2023

Webrevs

Copy link
Member

@stefank stefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for finding and fixing this.

@openjdk
Copy link

openjdk bot commented Aug 25, 2023

@JonasNorlinder This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314990: Generational ZGC: Strong OopStorage stats reported as weak roots

Reviewed-by: stefank, eosterlund

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 002b594: 8312749: Generational ZGC: Tests crash with assert(index == 0 || is_power_of_2(index))
  • d024059: 8314951: VM build without C2 still fails after JDK-8313530
  • 2624324: 8219567: Name of first parameter of RandomAccessFile(String,String) is inconsistent
  • 8e4240c: 8314850: SharedRuntime::handle_wrong_method() gets called too often when resolving Continuation.enter
  • d9fc6b6: 8314759: VirtualThread.parkNanos timeout adjustment when pinned should be replaced
  • acaab6f: 8306040: HttpResponseInputStream.available() returns 1 on empty stream

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@stefank, @fisk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 25, 2023
@JonasNorlinder
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 25, 2023
@openjdk
Copy link

openjdk bot commented Aug 25, 2023

@JonasNorlinder
Your change (at version 68ee8fe) is now ready to be sponsored by a Committer.

Copy link
Contributor

@fisk fisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@stefank
Copy link
Member

stefank commented Aug 25, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 25, 2023

Going to push as commit dcd6e75.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 002b594: 8312749: Generational ZGC: Tests crash with assert(index == 0 || is_power_of_2(index))
  • d024059: 8314951: VM build without C2 still fails after JDK-8313530
  • 2624324: 8219567: Name of first parameter of RandomAccessFile(String,String) is inconsistent
  • 8e4240c: 8314850: SharedRuntime::handle_wrong_method() gets called too often when resolving Continuation.enter
  • d9fc6b6: 8314759: VirtualThread.parkNanos timeout adjustment when pinned should be replaced
  • acaab6f: 8306040: HttpResponseInputStream.available() returns 1 on empty stream

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 25, 2023
@openjdk openjdk bot closed this Aug 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 25, 2023
@openjdk
Copy link

openjdk bot commented Aug 25, 2023

@stefank @JonasNorlinder Pushed as commit dcd6e75.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants