8308464: Shared array class should not always be loaded in boot loader

[calvinccheung]

Please review this fix for using the appropriate class loader when loading a shared array class. The log output from -Xlog:cds+unshareable=trace is also updated to include the class loader information.

For example:
before:
[0.203s][trace][cds,unshareable ] restore: ArrayKlassesApp

after:
[0.203s][trace][cds,unshareable ] restore: ArrayKlassesApp with class loader: jdk.internal.loader.ClassLoaders$AppClassLoader

Passed tiers 1- 3 tests.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8308464: Shared array class should not always be loaded in boot loader (Bug - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Ioi Lam (@iklam - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15421/head:pull/15421
$ git checkout pull/15421

Update a local copy of the PR:
$ git checkout pull/15421
$ git pull https://git.openjdk.org/jdk.git pull/15421/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15421

View PR using the GUI difftool:
$ git pr show -t 15421

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15421.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@calvinccheung The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[calvinccheung]

/label add hotspot-runtime

[openjdk]

@calvinccheung
The hotspot-runtime label was successfully added.

[mlbridge]

Webrevs

• 00: Full (8ff5f0e3)

[dholmes-ora]

LGTM. Thanks.

[openjdk]

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308464: Shared array class should not always be loaded in boot loader

Reviewed-by: dholmes, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 53 new commits pushed to the master branch:

• 69d1feb: 8315060: Out of tree incremental build fails with ccache
• 8e2a533: 8315137: Add explicit override RecordComponentElement.asType()
• b4b2fec: 8311081: KeytoolReaderP12Test.java fail on localized Windows platform
• 31e2681: 8315071: Modify TrayIconScalingTest.java, PrintLatinCJKTest.java to use new PassFailJFrame's builder pattern usage
• 21916f3: 8139208: [macosx] Issue with setExtendedState of JFrame
• 99ea8bf: 8315062: [GHA] get-bootjdk action should return the abolute path
• acb24bf: 8315116: fix minor issue in copyright header introduced by JDK-8269957 that is breaking the build
• 11da15d: 8269957: facilitate alternate impls of NameTable and Name
• 725ec0c: 8315020: The macro definition for LoongArch64 zero build is not accurate.
• 1c3177e: 8315029: [BACKOUT] Generational ZGC: Tests crash with assert(index == 0 || is_power_of_2(index))
• ... and 43 more: https://git.openjdk.org/jdk/compare/62610203f18095cbd25b456f0622bad033a65a5d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[iklam]

LGTM.

[calvinccheung]

Thanks @dholmes-ora, @iklam for the review!

/integrate

[openjdk]

Going to push as commit 1cb2cc6.
Since your change was applied there have been 53 commits pushed to the master branch:

• 69d1feb: 8315060: Out of tree incremental build fails with ccache
• 8e2a533: 8315137: Add explicit override RecordComponentElement.asType()
• b4b2fec: 8311081: KeytoolReaderP12Test.java fail on localized Windows platform
• 31e2681: 8315071: Modify TrayIconScalingTest.java, PrintLatinCJKTest.java to use new PassFailJFrame's builder pattern usage
• 21916f3: 8139208: [macosx] Issue with setExtendedState of JFrame
• 99ea8bf: 8315062: [GHA] get-bootjdk action should return the abolute path
• acb24bf: 8315116: fix minor issue in copyright header introduced by JDK-8269957 that is breaking the build
• 11da15d: 8269957: facilitate alternate impls of NameTable and Name
• 725ec0c: 8315020: The macro definition for LoongArch64 zero build is not accurate.
• 1c3177e: 8315029: [BACKOUT] Generational ZGC: Tests crash with assert(index == 0 || is_power_of_2(index))
• ... and 43 more: https://git.openjdk.org/jdk/compare/62610203f18095cbd25b456f0622bad033a65a5d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@calvinccheung Pushed as commit 1cb2cc6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.