Skip to content

Conversation

@rhalade
Copy link
Member

@rhalade rhalade commented Aug 25, 2023

This PR is to add new TLS root certificates from Certigna (Dhimyotis). This CA has gone through https://www.oracle.com/java/technologies/javase/carootcertsprogram.html process.

The release-note is at JDK-8314976


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314960: Add Certigna Root CA - 2 (Enhancement - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15425/head:pull/15425
$ git checkout pull/15425

Update a local copy of the PR:
$ git checkout pull/15425
$ git pull https://git.openjdk.org/jdk.git pull/15425/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15425

View PR using the GUI difftool:
$ git pr show -t 15425

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15425.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 25, 2023

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 25, 2023
@openjdk
Copy link

openjdk bot commented Aug 25, 2023

@rhalade The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Aug 25, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 25, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 25, 2023

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314960: Add Certigna Root CA - 2

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

  • 7342f5a: 8314333: Update com/sun/jdi/ProcessAttachTest.java to use ProcessTools.createTestJvm(..)
  • f139f30: 8315033: Problemlist java/lang/template/StringTemplateTest.java
  • f2383b3: 8314063: The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection
  • dcd6e75: 8314990: Generational ZGC: Strong OopStorage stats reported as weak roots
  • 002b594: 8312749: Generational ZGC: Tests crash with assert(index == 0 || is_power_of_2(index))
  • d024059: 8314951: VM build without C2 still fails after JDK-8313530
  • 2624324: 8219567: Name of first parameter of RandomAccessFile(String,String) is inconsistent
  • 8e4240c: 8314850: SharedRuntime::handle_wrong_method() gets called too often when resolving Continuation.enter
  • d9fc6b6: 8314759: VirtualThread.parkNanos timeout adjustment when pinned should be replaced
  • acaab6f: 8306040: HttpResponseInputStream.available() returns 1 on empty stream
  • ... and 32 more: https://git.openjdk.org/jdk/compare/ce1ded1a4f36b55717793f2bed4a64ce0353fc34...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 25, 2023
@rhalade
Copy link
Member Author

rhalade commented Aug 25, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Aug 25, 2023

Going to push as commit e9ba8d5.
Since your change was applied there have been 43 commits pushed to the master branch:

  • 837cf85: 8312547: Max/Min nodes Value implementation could be improved
  • 7342f5a: 8314333: Update com/sun/jdi/ProcessAttachTest.java to use ProcessTools.createTestJvm(..)
  • f139f30: 8315033: Problemlist java/lang/template/StringTemplateTest.java
  • f2383b3: 8314063: The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection
  • dcd6e75: 8314990: Generational ZGC: Strong OopStorage stats reported as weak roots
  • 002b594: 8312749: Generational ZGC: Tests crash with assert(index == 0 || is_power_of_2(index))
  • d024059: 8314951: VM build without C2 still fails after JDK-8313530
  • 2624324: 8219567: Name of first parameter of RandomAccessFile(String,String) is inconsistent
  • 8e4240c: 8314850: SharedRuntime::handle_wrong_method() gets called too often when resolving Continuation.enter
  • d9fc6b6: 8314759: VirtualThread.parkNanos timeout adjustment when pinned should be replaced
  • ... and 33 more: https://git.openjdk.org/jdk/compare/ce1ded1a4f36b55717793f2bed4a64ce0353fc34...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 25, 2023
@openjdk openjdk bot closed this Aug 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 25, 2023
@openjdk
Copy link

openjdk bot commented Aug 25, 2023

@rhalade Pushed as commit e9ba8d5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@rhalade rhalade deleted the certigna-update branch August 25, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants