Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315033: Problemlist java/lang/template/StringTemplateTest.java #15430

Closed
wants to merge 1 commit into from

Conversation

robcasloz
Copy link
Contributor

@robcasloz robcasloz commented Aug 25, 2023

This changeset problem-lists java/lang/template/StringTemplateTest.java, which fails intermittently after the integration of JDK-8312749, to reduce CI pipeline noise while JDK-8315029 is investigated.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315033: Problemlist java/lang/template/StringTemplateTest.java (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15430/head:pull/15430
$ git checkout pull/15430

Update a local copy of the PR:
$ git checkout pull/15430
$ git pull https://git.openjdk.org/jdk.git pull/15430/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15430

View PR using the GUI difftool:
$ git pr show -t 15430

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15430.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 25, 2023

👋 Welcome back rcastanedalo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 25, 2023

@robcasloz To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@robcasloz robcasloz changed the title 8315033: Problemlist test failing intermittently after JDK-8312749 8315033: Problemlist java/lang/template/StringTemplateTest.java Aug 25, 2023
@robcasloz
Copy link
Contributor Author

/label add hotspot-compiler

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Aug 25, 2023
@openjdk
Copy link

openjdk bot commented Aug 25, 2023

@robcasloz
The hotspot-compiler label was successfully added.

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial!

@robcasloz robcasloz marked this pull request as ready for review August 25, 2023 15:04
@openjdk
Copy link

openjdk bot commented Aug 25, 2023

@robcasloz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315033: Problemlist java/lang/template/StringTemplateTest.java

Reviewed-by: chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 25, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 25, 2023

Webrevs

@robcasloz
Copy link
Contributor Author

Looks good and trivial!

Thanks, Christian!

@robcasloz
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 25, 2023

Going to push as commit f139f30.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 25, 2023
@openjdk openjdk bot closed this Aug 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 25, 2023
@openjdk
Copy link

openjdk bot commented Aug 25, 2023

@robcasloz Pushed as commit f139f30.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants