8313430: [JVMCI] fatal error: Never compilable: in JVMCI shutdown

[dougxc]

VM shutdown involves calling Java code which can schedule further compilations by the CompileBroker. With UseJVMCICompiler, all compilations started once VM shutdown has begun are abandoned since they are unnecessary and can delay VM shutdown.

This PR makes -XX:+AbortVMOnCompilationFailure ignore such abandoned compilations.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8313430: [JVMCI] fatal error: Never compilable: in JVMCI shutdown (Bug - P4)

Reviewers

• Tom Rodriguez (@tkrodriguez - Reviewer) ⚠️ Review applies to 8900b1c0
• Vladimir Kozlov (@vnkozlov - Reviewer) ⚠️ Review applies to 8900b1c0
• Aleksey Shipilev (@shipilev - Reviewer) ⚠️ Review applies to 8900b1c0

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15433/head:pull/15433
$ git checkout pull/15433

Update a local copy of the PR:
$ git checkout pull/15433
$ git pull https://git.openjdk.org/jdk.git pull/15433/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15433

View PR using the GUI difftool:
$ git pr show -t 15433

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15433.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[tkrodriguez]

Looks good.

[openjdk]

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313430: [JVMCI] fatal error: Never compilable: in JVMCI shutdown

Reviewed-by: never, kvn, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dougxc The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (94981bbf)
• 00: Full (8900b1c0)

[vnkozlov]

Good.

[shipilev]

Nit: There is a double space in here.

[dougxc]

Thanks for the reviews.

/integrate

[openjdk]

Going to push as commit acd9310.
Since your change was applied there have been 4 commits pushed to the master branch:

• 8a5db6b: 8237542: JMapHeapConfigTest.java doesn't work with negative jlong values
• d0cc043: 8314550: [macosx-aarch64] serviceability/sa/TestJmapCore.java fails with "sun.jvm.hotspot.debugger.UnmappedAddressException: 801000800"
• 837d2e1: 8314483: Optionally override copyright header in generated source
• 3201623: 8310454: Introduce static-libs-graal bundle

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc Pushed as commit acd9310.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.