Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315062: [GHA] get-bootjdk action should return the abolute path #15435

Closed
wants to merge 1 commit into from

Conversation

navyxliu
Copy link
Member

@navyxliu navyxliu commented Aug 25, 2023

We are running hotspot:tier2 on github action(GHA). I have difficulty to execute this test on GHA:
Runtime/cds/appcds/dynamicArchive/TestAutoCreateSharedArchiveUpgrade.java

In GHA, the java property is gained from environment variable BOOT_JDK.
BOOT_JDK=${{ steps.bootjdk.outputs.path }}

it is in turn from action get-bootjdk. now it returns a relative path. The aforementioned test has trouble to find the executable if the path relative.
I would recommend changing the action get-bootjdk. we just return the absolute path.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315062: [GHA] get-bootjdk action should return the abolute path (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15435/head:pull/15435
$ git checkout pull/15435

Update a local copy of the PR:
$ git checkout pull/15435
$ git pull https://git.openjdk.org/jdk.git pull/15435/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15435

View PR using the GUI difftool:
$ git pr show -t 15435

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15435.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 25, 2023

👋 Welcome back xliu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 25, 2023
@openjdk
Copy link

openjdk bot commented Aug 25, 2023

@navyxliu The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Aug 25, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 25, 2023

Webrevs

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Aug 28, 2023

@navyxliu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315062: [GHA] get-bootjdk action should return the abolute path

Reviewed-by: clanger, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 725ec0c: 8315020: The macro definition for LoongArch64 zero build is not accurate.
  • 1c3177e: 8315029: [BACKOUT] Generational ZGC: Tests crash with assert(index == 0 || is_power_of_2(index))
  • dd23f7d: 8315039: Parallel: Remove unimplemented PSYoungGen::oop_iterate
  • 5c4f1dc: 8314513: [IR Framework] Some internal IR Framework tests are failing after JDK-8310308 on PPC and Cascade Lake
  • cf2d33c: 8299658: C1 compilation crashes in LinearScan::resolve_exception_edge
  • 1664e79: 8311792: java/net/httpclient/ResponsePublisher.java fails intermittently with AssertionError: Found some outstanding operations
  • 0901d75: 8314762: Make {@Incubating} conventional
  • 12de9b0: 8314148: Fix variable scope in SunMSCAPI
  • 7fbad4c: 8310596: Utilize existing method frame::interpreter_frame_monitor_size_in_bytes()
  • 752a438: 8314684: Add overview docs to loaderConstraints.cpp
  • ... and 2 more: https://git.openjdk.org/jdk/compare/d0cc0439c07ad0cca611e1999eda37f20c5a99d0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 28, 2023
@navyxliu
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 28, 2023

Going to push as commit 99ea8bf.
Since your change was applied there have been 14 commits pushed to the master branch:

  • acb24bf: 8315116: fix minor issue in copyright header introduced by JDK-8269957 that is breaking the build
  • 11da15d: 8269957: facilitate alternate impls of NameTable and Name
  • 725ec0c: 8315020: The macro definition for LoongArch64 zero build is not accurate.
  • 1c3177e: 8315029: [BACKOUT] Generational ZGC: Tests crash with assert(index == 0 || is_power_of_2(index))
  • dd23f7d: 8315039: Parallel: Remove unimplemented PSYoungGen::oop_iterate
  • 5c4f1dc: 8314513: [IR Framework] Some internal IR Framework tests are failing after JDK-8310308 on PPC and Cascade Lake
  • cf2d33c: 8299658: C1 compilation crashes in LinearScan::resolve_exception_edge
  • 1664e79: 8311792: java/net/httpclient/ResponsePublisher.java fails intermittently with AssertionError: Found some outstanding operations
  • 0901d75: 8314762: Make {@Incubating} conventional
  • 12de9b0: 8314148: Fix variable scope in SunMSCAPI
  • ... and 4 more: https://git.openjdk.org/jdk/compare/d0cc0439c07ad0cca611e1999eda37f20c5a99d0...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 28, 2023
@openjdk openjdk bot closed this Aug 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 28, 2023
@openjdk
Copy link

openjdk bot commented Aug 28, 2023

@navyxliu Pushed as commit 99ea8bf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants