Skip to content

8315071 : Modify TrayIconScalingTest.java, PrintLatinCJKTest.java to use new PassFailJFrame's builder pattern usage #15438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

lawrence-andrew
Copy link
Contributor

@lawrence-andrew lawrence-andrew commented Aug 26, 2023

Both the tests demonstrates how to use the PassFailJFrame's builder pattern.

  1. TrayIconScalingTest.java demonstrates how to add screen shot method
  2. PrintLatinCJKTest.java demonstrates how to use PassFailJFrame's builder pattern without screen shot method.

@aivanov-jdk
@honkar-jdk


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315071: Modify TrayIconScalingTest.java, PrintLatinCJKTest.java to use new PassFailJFrame's builder pattern usage (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15438/head:pull/15438
$ git checkout pull/15438

Update a local copy of the PR:
$ git checkout pull/15438
$ git pull https://git.openjdk.org/jdk.git pull/15438/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15438

View PR using the GUI difftool:
$ git pr show -t 15438

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15438.diff

Webrev

Link to Webrev Comment

…use new PassFailJFrame's builder pattern usage
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 26, 2023

👋 Welcome back lawrence-andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 26, 2023
@openjdk
Copy link

openjdk bot commented Aug 26, 2023

@lawrence-andrew The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Aug 26, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 26, 2023

Webrevs

Copy link
Contributor

@honkar-jdk honkar-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Aug 28, 2023

@lawrence-andrew This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315071: Modify TrayIconScalingTest.java, PrintLatinCJKTest.java to use new PassFailJFrame's builder pattern usage

Reviewed-by: honkar, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • 21916f3: 8139208: [macosx] Issue with setExtendedState of JFrame
  • 99ea8bf: 8315062: [GHA] get-bootjdk action should return the abolute path
  • acb24bf: 8315116: fix minor issue in copyright header introduced by JDK-8269957 that is breaking the build
  • 11da15d: 8269957: facilitate alternate impls of NameTable and Name
  • 725ec0c: 8315020: The macro definition for LoongArch64 zero build is not accurate.
  • 1c3177e: 8315029: [BACKOUT] Generational ZGC: Tests crash with assert(index == 0 || is_power_of_2(index))
  • dd23f7d: 8315039: Parallel: Remove unimplemented PSYoungGen::oop_iterate
  • 5c4f1dc: 8314513: [IR Framework] Some internal IR Framework tests are failing after JDK-8310308 on PPC and Cascade Lake
  • cf2d33c: 8299658: C1 compilation crashes in LinearScan::resolve_exception_edge
  • 1664e79: 8311792: java/net/httpclient/ResponsePublisher.java fails intermittently with AssertionError: Found some outstanding operations
  • ... and 4 more: https://git.openjdk.org/jdk/compare/acd93102348f592d6f2e77a4bff6037edf708d55...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@honkar-jdk, @aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 28, 2023
@lawrence-andrew
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 28, 2023
@openjdk
Copy link

openjdk bot commented Aug 28, 2023

@lawrence-andrew
Your change (at version aab3c4b) is now ready to be sponsored by a Committer.

@aivanov-jdk
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 28, 2023

Going to push as commit 31e2681.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 21916f3: 8139208: [macosx] Issue with setExtendedState of JFrame
  • 99ea8bf: 8315062: [GHA] get-bootjdk action should return the abolute path
  • acb24bf: 8315116: fix minor issue in copyright header introduced by JDK-8269957 that is breaking the build
  • 11da15d: 8269957: facilitate alternate impls of NameTable and Name
  • 725ec0c: 8315020: The macro definition for LoongArch64 zero build is not accurate.
  • 1c3177e: 8315029: [BACKOUT] Generational ZGC: Tests crash with assert(index == 0 || is_power_of_2(index))
  • dd23f7d: 8315039: Parallel: Remove unimplemented PSYoungGen::oop_iterate
  • 5c4f1dc: 8314513: [IR Framework] Some internal IR Framework tests are failing after JDK-8310308 on PPC and Cascade Lake
  • cf2d33c: 8299658: C1 compilation crashes in LinearScan::resolve_exception_edge
  • 1664e79: 8311792: java/net/httpclient/ResponsePublisher.java fails intermittently with AssertionError: Found some outstanding operations
  • ... and 4 more: https://git.openjdk.org/jdk/compare/acd93102348f592d6f2e77a4bff6037edf708d55...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 28, 2023
@openjdk openjdk bot closed this Aug 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 28, 2023
@openjdk
Copy link

openjdk bot commented Aug 28, 2023

@aivanov-jdk @lawrence-andrew Pushed as commit 31e2681.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants