Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257537: [vector] Cleanup redundant bitwise cases on floating point vectors #1544

Conversation

PaulSandoz
Copy link
Member

@PaulSandoz PaulSandoz commented Dec 1, 2020

Float/DoubleVector implementations contain redundant cases for bitwise operations. Such bitwise operations will fail on such FP vectors before the case is reached.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257537: [vector] Cleanup redundant bitwise cases on floating point vectors

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1544/head:pull/1544
$ git checkout pull/1544

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 1, 2020

👋 Welcome back psandoz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 1, 2020
@openjdk
Copy link

openjdk bot commented Dec 1, 2020

@PaulSandoz To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

@PaulSandoz PaulSandoz changed the title 8257537: [vector] Cleanup redundant bitwise cases on fp vectors 8257537: [vector] Cleanup redundant bitwise cases on floating point vectors Dec 1, 2020
@PaulSandoz
Copy link
Member Author

PaulSandoz commented Dec 1, 2020

/label add hotspot-compiler, core-libs

@openjdk openjdk bot added hotspot-compiler hotspot-compiler-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Dec 1, 2020
@openjdk
Copy link

openjdk bot commented Dec 1, 2020

@PaulSandoz
The hotspot-compiler label was successfully added.

The core-libs label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Dec 1, 2020

Webrevs

Copy link

@iwanowww iwanowww left a comment

Looks good.

@openjdk
Copy link

openjdk bot commented Dec 1, 2020

@PaulSandoz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257537: [vector] Cleanup redundant bitwise cases on floating point vectors

Reviewed-by: vlivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 015e6e5: 8257460: Further CompilerOracle cleanup
  • 29d90b9: 8255968: Confusing error message for inaccessible constructor
  • c5046ca: 8246739: InputStream.skipNBytes could be implemented more efficiently
  • 56b15fb: 8159746: (proxy) Support for default methods

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 1, 2020
@PaulSandoz
Copy link
Member Author

PaulSandoz commented Dec 2, 2020

/integrate

@openjdk openjdk bot closed this Dec 2, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 2, 2020
@openjdk
Copy link

openjdk bot commented Dec 2, 2020

@PaulSandoz Since your change was applied there have been 8 commits pushed to the master branch:

  • 03f3b8e: 8210253: Clipped UI rendering with X11 pipeline and HiDPI
  • ce496cb: 8257190: simplify PhaseIdealLoop constructors
  • 927504e: 8256474: Migrate Mutex _owner accesses to use Atomic operations
  • 00e79db: 8257511: JDK-8254082 brings regression to AbstractStringBuilder.insert(int dstOffset, CharSequence s, int start, int end)
  • 015e6e5: 8257460: Further CompilerOracle cleanup
  • 29d90b9: 8255968: Confusing error message for inaccessible constructor
  • c5046ca: 8246739: InputStream.skipNBytes could be implemented more efficiently
  • 56b15fb: 8159746: (proxy) Support for default methods

Your commit was automatically rebased without conflicts.

Pushed as commit cfd070e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@PaulSandoz PaulSandoz deleted the JDK-8257537-vector-fp-ops-cleannup branch Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
2 participants