8315029: [BACKOUT] Generational ZGC: Tests crash with assert(index == 0 || is_power_of_2(index))

[robcasloz]

This changeset backs out the changes introduced by JDK-8312749 and re-enables the problem-listed test/jdk/java/lang/template/StringTemplateTest.java. The backed-out issue will be re-addressed in JDK-8315082.

Testing

• tier1-3 (windows-x64, linux-x64, linux-aarch64, macosx-x64, and macosx-aarch64)
• test/jdk/java/lang/template/StringTemplateTest.java

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8315029: [BACKOUT] Generational ZGC: Tests crash with assert(index == 0 || is_power_of_2(index)) (Sub-task - P2)

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer)
• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15442/head:pull/15442
$ git checkout pull/15442

Update a local copy of the PR:
$ git checkout pull/15442
$ git pull https://git.openjdk.org/jdk.git pull/15442/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15442

View PR using the GUI difftool:
$ git pr show -t 15442

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15442.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rcastanedalo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@robcasloz The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[chhagedorn]

Looks good and trivial.

[openjdk]

@robcasloz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315029: [BACKOUT] Generational ZGC: Tests crash with assert(index == 0 || is_power_of_2(index))

Reviewed-by: chagedorn, mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 5c4f1dc: 8314513: [IR Framework] Some internal IR Framework tests are failing after JDK-8310308 on PPC and Cascade Lake
• cf2d33c: 8299658: C1 compilation crashes in LinearScan::resolve_exception_edge
• 1664e79: 8311792: java/net/httpclient/ResponsePublisher.java fails intermittently with AssertionError: Found some outstanding operations
• 0901d75: 8314762: Make {@Incubating} conventional

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (bb6bba90)

[TheRealMDoerr]

LGTM.

[robcasloz]

Thanks Christian and Martin!

[robcasloz]

/integrate

[openjdk]

Going to push as commit 1c3177e.
Since your change was applied there have been 5 commits pushed to the master branch:

• dd23f7d: 8315039: Parallel: Remove unimplemented PSYoungGen::oop_iterate
• 5c4f1dc: 8314513: [IR Framework] Some internal IR Framework tests are failing after JDK-8310308 on PPC and Cascade Lake
• cf2d33c: 8299658: C1 compilation crashes in LinearScan::resolve_exception_edge
• 1664e79: 8311792: java/net/httpclient/ResponsePublisher.java fails intermittently with AssertionError: Found some outstanding operations
• 0901d75: 8314762: Make {@Incubating} conventional

Your commit was automatically rebased without conflicts.

[openjdk]

@robcasloz Pushed as commit 1c3177e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.