Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315051: jdk/jfr/jvm/TestGetEventWriter.java fails with non-JVMCI GCs #15446

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Aug 28, 2023

See the bug for example test failure. There are two ways to fix it: bring in Whitebox and sense the JVMCI support from there, or use the @requires to sense this and other conditions for JVMCI enablement then. @requires seems safer, so I did that one.

Additional testing:

  • Affected test with -XX:+UseShenandoahGC (now passes)
  • Affected test with -XX:+UseParallelGC (still passes)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315051: jdk/jfr/jvm/TestGetEventWriter.java fails with non-JVMCI GCs (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15446/head:pull/15446
$ git checkout pull/15446

Update a local copy of the PR:
$ git checkout pull/15446
$ git pull https://git.openjdk.org/jdk.git pull/15446/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15446

View PR using the GUI difftool:
$ git pr show -t 15446

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15446.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 28, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 28, 2023
@openjdk
Copy link

openjdk bot commented Aug 28, 2023

@shipilev The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Aug 28, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 28, 2023

Webrevs

@JohnTortugo
Copy link
Contributor

For what's worth: LGTM

@openjdk
Copy link

openjdk bot commented Aug 29, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315051: jdk/jfr/jvm/TestGetEventWriter.java fails with non-JVMCI GCs

Reviewed-by: phh, egahlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 80 new commits pushed to the master branch:

  • 486fa08: 8313873: java/nio/channels/DatagramChannel/SendReceiveMaxSize.java fails on AIX due to small default RCVBUF size and different IPv6 Header interpretation
  • b0353ad: 8315242: G1: Fix -Wconversion warnings around GCDrainStackTargetSize
  • b594f01: 8314748: 1-10% regressions on Crypto micros
  • 39f1813: 8315318: Typo in comment on sun.nio.ch.Net.unblock4
  • 47aa6f3: 8315219: G1: Improve allocator pathological case where it keeps doing direct allocations instead of retiring a PLAB
  • 218829e: 8315421: [BACKOUT] 8314834 serviceability/jdwp/AllModulesCommandTest.java ignores VM flags
  • 3c8a667: 8314611: Provide more explicative error message parsing Currencies
  • df5e6e5: 8315248: AssertionError in Name.compareTo
  • 3eac890: 8315061: Make LockingMode a product flag
  • 8419a53: 8315072: Remove unneeded AdaptivePaddedAverage::operator new
  • ... and 70 more: https://git.openjdk.org/jdk/compare/de0e46c2f6dfa817bfa745195573810d250640de...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 29, 2023
@shipilev
Copy link
Member Author

Thanks for reviews. @egahlin, you modified this test a lot of times, are you good with this?

@shipilev
Copy link
Member Author

Thanks!

/integrate

@openjdk
Copy link

openjdk bot commented Aug 31, 2023

Going to push as commit 145d8bc.
Since your change was applied there have been 80 commits pushed to the master branch:

  • 486fa08: 8313873: java/nio/channels/DatagramChannel/SendReceiveMaxSize.java fails on AIX due to small default RCVBUF size and different IPv6 Header interpretation
  • b0353ad: 8315242: G1: Fix -Wconversion warnings around GCDrainStackTargetSize
  • b594f01: 8314748: 1-10% regressions on Crypto micros
  • 39f1813: 8315318: Typo in comment on sun.nio.ch.Net.unblock4
  • 47aa6f3: 8315219: G1: Improve allocator pathological case where it keeps doing direct allocations instead of retiring a PLAB
  • 218829e: 8315421: [BACKOUT] 8314834 serviceability/jdwp/AllModulesCommandTest.java ignores VM flags
  • 3c8a667: 8314611: Provide more explicative error message parsing Currencies
  • df5e6e5: 8315248: AssertionError in Name.compareTo
  • 3eac890: 8315061: Make LockingMode a product flag
  • 8419a53: 8315072: Remove unneeded AdaptivePaddedAverage::operator new
  • ... and 70 more: https://git.openjdk.org/jdk/compare/de0e46c2f6dfa817bfa745195573810d250640de...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 31, 2023
@openjdk openjdk bot closed this Aug 31, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 31, 2023
@openjdk
Copy link

openjdk bot commented Aug 31, 2023

@shipilev Pushed as commit 145d8bc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8315051-jfr-geteventwriter-jvmci branch November 28, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
4 participants