Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315206: RISC-V: hwprobe query is_set return wrong value #15464

Closed
wants to merge 1 commit into from

Conversation

robehn
Copy link
Contributor

@robehn robehn commented Aug 29, 2023

Hi, please consider this bug fix.

Manually tested with modified qemu.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315206: RISC-V: hwprobe query is_set return wrong value (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15464/head:pull/15464
$ git checkout pull/15464

Update a local copy of the PR:
$ git checkout pull/15464
$ git pull https://git.openjdk.org/jdk.git pull/15464/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15464

View PR using the GUI difftool:
$ git pr show -t 15464

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15464.diff

Webrev

Link to Webrev Comment

@robehn robehn closed this Aug 29, 2023
@robehn robehn changed the title RISC-V: hwprobe query is_set return wrong value 8315206: RISC-V: hwprobe query is_set return wrong value Aug 29, 2023
@robehn robehn reopened this Aug 29, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 29, 2023

👋 Welcome back rehn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 29, 2023
@openjdk
Copy link

openjdk bot commented Aug 29, 2023

@robehn The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Aug 29, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 29, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 29, 2023

@robehn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315206: RISC-V: hwprobe query is_set return wrong value

Reviewed-by: luhenry, fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 5cc64cc: 8309463: IGV: Dynamic graph layout algorithm
  • 1d02507: 8314476: TestJstatdPortAndServer.java failed with "java.rmi.NoSuchObjectException: no such object in table"
  • 93188bd: 8314569: (fs) Improve normalization of UnixPath for input with trailing slashes
  • 8b8182d: 8315087: G1: Use uint for G1 flags indicating percentage

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 29, 2023
@robehn
Copy link
Contributor Author

robehn commented Aug 30, 2023

Thanks @luhenry @RealFYang !

/integrate

@openjdk
Copy link

openjdk bot commented Aug 30, 2023

Going to push as commit 876a725.
Since your change was applied there have been 13 commits pushed to the master branch:

  • ed1ea5f: 8314024: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work due to bad immediate dominator info
  • f3aeb02: 8315213: java/lang/ProcessHandle/TreeTest.java test enhance output of children
  • 1e7e2bc: 8315214: Do not run sun/tools/jhsdb tests concurrently
  • ce2a7ea: 8314056: Remove runtime platform check from frem/drem
  • 1c598c2: 8312428: PKCS11 tests fail with NSS 3.91
  • b2728cb: 8189685: need PerfMemory class update and a volatile_static_field support in VMStructs
  • e22762c: 8314932: G1: Fix -Wconversion warnings for simple cases inside g1 folder
  • 762b652: 8314573: G1: Heap resizing at Remark does not take existing eden regions into account
  • a4e97aa: 8314753: Remove support for @beaninfo, @todo, @since.unbundled, and @note
  • 5cc64cc: 8309463: IGV: Dynamic graph layout algorithm
  • ... and 3 more: https://git.openjdk.org/jdk/compare/3dc266c58bf92b8f072ad5bcc3ac6962c06c35a9...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 30, 2023
@openjdk openjdk bot closed this Aug 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 30, 2023
@openjdk
Copy link

openjdk bot commented Aug 30, 2023

@robehn Pushed as commit 876a725.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@robehn
Copy link
Contributor Author

robehn commented Aug 31, 2023

/backport jdk21

@openjdk
Copy link

openjdk bot commented Aug 31, 2023

@robehn the backport was successfully created on the branch robehn-backport-876a725a in my personal fork of openjdk/jdk21. To create a pull request with this backport targeting openjdk/jdk21:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 876a725a from the openjdk/jdk repository.

The commit being backported was authored by Robbin Ehn on 30 Aug 2023 and was reviewed by Ludovic Henry and Fei Yang.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21:

$ git fetch https://github.com/openjdk-bots/jdk21.git robehn-backport-876a725a:robehn-backport-876a725a
$ git checkout robehn-backport-876a725a
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21.git robehn-backport-876a725a

@robehn
Copy link
Contributor Author

robehn commented Sep 1, 2023

/backport jdk21u

@openjdk
Copy link

openjdk bot commented Sep 1, 2023

@robehn the backport was successfully created on the branch robehn-backport-876a725a in my personal fork of openjdk/jdk21u. To create a pull request with this backport targeting openjdk/jdk21u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 876a725a from the openjdk/jdk repository.

The commit being backported was authored by Robbin Ehn on 30 Aug 2023 and was reviewed by Ludovic Henry and Fei Yang.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u:

$ git fetch https://github.com/openjdk-bots/jdk21u.git robehn-backport-876a725a:robehn-backport-876a725a
$ git checkout robehn-backport-876a725a
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u.git robehn-backport-876a725a

@robehn robehn deleted the 8315206 branch October 9, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants