Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8315214: Do not run sun/tools/jhsdb tests concurrently #15469

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Aug 29, 2023

The sun/tools/jhsdb tests have issues when we run them concurrently .
So add a related config to TEST.root.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315214: Do not run sun/tools/jhsdb tests concurrently (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15469/head:pull/15469
$ git checkout pull/15469

Update a local copy of the PR:
$ git checkout pull/15469
$ git pull https://git.openjdk.org/jdk.git pull/15469/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15469

View PR using the GUI difftool:
$ git pr show -t 15469

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15469.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 29, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 29, 2023
@openjdk
Copy link

openjdk bot commented Aug 29, 2023

@MBaesken The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Aug 29, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 29, 2023

Webrevs

@AlanBateman
Copy link
Contributor

/label remove core-libs
/label add serviceability

@openjdk openjdk bot removed the core-libs core-libs-dev@openjdk.org label Aug 29, 2023
@openjdk
Copy link

openjdk bot commented Aug 29, 2023

@AlanBateman
The core-libs label was successfully removed.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Aug 29, 2023
@openjdk
Copy link

openjdk bot commented Aug 29, 2023

@AlanBateman
The serviceability label was successfully added.

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay to me

@openjdk
Copy link

openjdk bot commented Aug 29, 2023

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315214: Do not run sun/tools/jhsdb tests concurrently

Reviewed-by: alanb, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • e22762c: 8314932: G1: Fix -Wconversion warnings for simple cases inside g1 folder
  • 762b652: 8314573: G1: Heap resizing at Remark does not take existing eden regions into account

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 29, 2023
@MBaesken
Copy link
Member Author

Hi Alan and Chris , thanks for the reviews !

/integrate

@openjdk
Copy link

openjdk bot commented Aug 30, 2023

Going to push as commit 1e7e2bc.
Since your change was applied there have been 5 commits pushed to the master branch:

  • ce2a7ea: 8314056: Remove runtime platform check from frem/drem
  • 1c598c2: 8312428: PKCS11 tests fail with NSS 3.91
  • b2728cb: 8189685: need PerfMemory class update and a volatile_static_field support in VMStructs
  • e22762c: 8314932: G1: Fix -Wconversion warnings for simple cases inside g1 folder
  • 762b652: 8314573: G1: Heap resizing at Remark does not take existing eden regions into account

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 30, 2023
@openjdk openjdk bot closed this Aug 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 30, 2023
@openjdk
Copy link

openjdk bot commented Aug 30, 2023

@MBaesken Pushed as commit 1e7e2bc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
3 participants