8314925: ChoiceFormat does not specify IllegalArgumentExceptions

[justin-curtis-lu]

Please review this PR and CSR which is a conformance change to specify exceptions in java.text.ChoiceFormat.

Makes IllegalArgumentException apparent for applyPattern and setChoices, as well as for the associated constructors that call the methods.

This change also improves the error message for the setChoices IAE.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8315148 to be approved

Issues

• JDK-8314925: ChoiceFormat does not specify IllegalArgumentExceptions (Bug - P4)
• JDK-8315148: ChoiceFormat does not specify IllegalArgumentExceptions (CSR)

Reviewers

• Naoto Sato (@naotoj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15473/head:pull/15473
$ git checkout pull/15473

Update a local copy of the PR:
$ git checkout pull/15473
$ git pull https://git.openjdk.org/jdk.git pull/15473/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15473

View PR using the GUI difftool:
$ git pr show -t 15473

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15473.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@justin-curtis-lu The following labels will be automatically applied to this pull request:

• core-libs
• i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[justin-curtis-lu]

This would probably more informative if it was changed to IllegalArgumentException if {@code newPattern} violates the ChoiceFormat pattern syntax.

However, as of now I kept it this way because there is no defined syntax ATM (although I have a PR for that here -> #15392) and the other Format classes all also follow the "... is invalid" wording.

[mlbridge]

Webrevs

• 00: Full (e438e777)

[openjdk]

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314925: ChoiceFormat does not specify IllegalArgumentExceptions

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

• 63f561f: 8306882: (fs) Path.toRealPath(LinkOption.NOFOLLOW_LINKS) fails when "../../" follows a link
• 2436fb0: 8312306: Add more Reference.reachabilityFence() calls to the security classes using Cleaner
• 351c31e: 8315378: [BACKOUT] runtime/NMT/SummarySanityCheck.java failed with "Total committed (MMMMMM) did not match the summarized committed (NNNNNN)"
• c12ca88: 8312521: Unused field LocaleProviderAdapter#defaultLocaleProviderAdapter could be removed
• b38bcae: 8313656: assert(!JvmtiExport::can_support_virtual_threads()) with -XX:-DoJVMTIVirtualThreadTransitions
• c8acab1: 8315413: Remove special filtering of Continuation.yield0 in StackWalker
• ea5aa61: 8315383: jlink SystemModulesPlugin incorrectly parses the options
• 29ff1e4: 8315445: 8314748 causes crashes in x64 builds
• 145d8bc: 8315051: jdk/jfr/jvm/TestGetEventWriter.java fails with non-JVMCI GCs
• 486fa08: 8313873: java/nio/channels/DatagramChannel/SendReceiveMaxSize.java fails on AIX due to small default RCVBUF size and different IPv6 Header interpretation
• ... and 44 more: https://git.openjdk.org/jdk/compare/99ea8bf2b962011e57d02a93217d65d7259e8f80...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[justin-curtis-lu]

/integrate

[openjdk]

Going to push as commit 7754ac0.
Since your change was applied there have been 56 commits pushed to the master branch:

• 2264667: 8315422: getSoTimeout() would be in try block in SSLSocketImpl
• d5973bd: 6333341: [BI] Doc: java.text.BreakIterator class specification is unclear
• 63f561f: 8306882: (fs) Path.toRealPath(LinkOption.NOFOLLOW_LINKS) fails when "../../" follows a link
• 2436fb0: 8312306: Add more Reference.reachabilityFence() calls to the security classes using Cleaner
• 351c31e: 8315378: [BACKOUT] runtime/NMT/SummarySanityCheck.java failed with "Total committed (MMMMMM) did not match the summarized committed (NNNNNN)"
• c12ca88: 8312521: Unused field LocaleProviderAdapter#defaultLocaleProviderAdapter could be removed
• b38bcae: 8313656: assert(!JvmtiExport::can_support_virtual_threads()) with -XX:-DoJVMTIVirtualThreadTransitions
• c8acab1: 8315413: Remove special filtering of Continuation.yield0 in StackWalker
• ea5aa61: 8315383: jlink SystemModulesPlugin incorrectly parses the options
• 29ff1e4: 8315445: 8314748 causes crashes in x64 builds
• ... and 46 more: https://git.openjdk.org/jdk/compare/99ea8bf2b962011e57d02a93217d65d7259e8f80...master

Your commit was automatically rebased without conflicts.

[openjdk]

@justin-curtis-lu Pushed as commit 7754ac0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.