Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315383: jlink SystemModulesPlugin incorrectly parses the options #15495

Closed
wants to merge 2 commits into from

Conversation

koppor
Copy link
Contributor

@koppor koppor commented Aug 30, 2023

Fixes https://bugs.openjdk.org/browse/JDK-8315383


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315383: jlink SystemModulesPlugin incorrectly parses the options (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15495/head:pull/15495
$ git checkout pull/15495

Update a local copy of the PR:
$ git checkout pull/15495
$ git pull https://git.openjdk.org/jdk.git pull/15495/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15495

View PR using the GUI difftool:
$ git pr show -t 15495

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15495.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 30, 2023

👋 Welcome back koppor! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 30, 2023
@openjdk
Copy link

openjdk bot commented Aug 30, 2023

@koppor The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Aug 30, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 30, 2023

Webrevs

Copy link
Member

@mlchung mlchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for catching this.

There are a few unused imports in JLinkDedupTestBatchSizeOne.java. Can you remove them as you are in that file?

@openjdk
Copy link

openjdk bot commented Aug 30, 2023

@koppor This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315383: jlink SystemModulesPlugin incorrectly parses the options

Reviewed-by: mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • 218829e: 8315421: [BACKOUT] 8314834 serviceability/jdwp/AllModulesCommandTest.java ignores VM flags
  • 3c8a667: 8314611: Provide more explicative error message parsing Currencies
  • df5e6e5: 8315248: AssertionError in Name.compareTo
  • 3eac890: 8315061: Make LockingMode a product flag
  • 8419a53: 8315072: Remove unneeded AdaptivePaddedAverage::operator new
  • c90cd2c: 8286789: Test forceEarlyReturn002.java timed out
  • 89d18ea: 8312018: Improve reservation of class space and CDS
  • dd64a4a: 8315241: (fs) Move toRealPath tests in java/nio/file/Path/Misc.java to separate JUnit 5 test
  • 8e4cda0: 8314834: serviceability/jdwp/AllModulesCommandTest.java ignores VM flags
  • 1ea6463: 8314835: gtest wrappers should be marked as flagless
  • ... and 8 more: https://git.openjdk.org/jdk/compare/f3aeb024d91c2d2088359d261be9a4b56a90663c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mlchung) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 30, 2023
@koppor
Copy link
Contributor Author

koppor commented Aug 31, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 31, 2023
@openjdk
Copy link

openjdk bot commented Aug 31, 2023

@koppor
Your change (at version d929f9a) is now ready to be sponsored by a Committer.

@mlchung
Copy link
Member

mlchung commented Aug 31, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 31, 2023

Going to push as commit ea5aa61.
Since your change was applied there have been 25 commits pushed to the master branch:

  • 29ff1e4: 8315445: 8314748 causes crashes in x64 builds
  • 145d8bc: 8315051: jdk/jfr/jvm/TestGetEventWriter.java fails with non-JVMCI GCs
  • 486fa08: 8313873: java/nio/channels/DatagramChannel/SendReceiveMaxSize.java fails on AIX due to small default RCVBUF size and different IPv6 Header interpretation
  • b0353ad: 8315242: G1: Fix -Wconversion warnings around GCDrainStackTargetSize
  • b594f01: 8314748: 1-10% regressions on Crypto micros
  • 39f1813: 8315318: Typo in comment on sun.nio.ch.Net.unblock4
  • 47aa6f3: 8315219: G1: Improve allocator pathological case where it keeps doing direct allocations instead of retiring a PLAB
  • 218829e: 8315421: [BACKOUT] 8314834 serviceability/jdwp/AllModulesCommandTest.java ignores VM flags
  • 3c8a667: 8314611: Provide more explicative error message parsing Currencies
  • df5e6e5: 8315248: AssertionError in Name.compareTo
  • ... and 15 more: https://git.openjdk.org/jdk/compare/f3aeb024d91c2d2088359d261be9a4b56a90663c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 31, 2023
@openjdk openjdk bot closed this Aug 31, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 31, 2023
@openjdk
Copy link

openjdk bot commented Aug 31, 2023

@mlchung @koppor Pushed as commit ea5aa61.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@koppor
Copy link
Contributor Author

koppor commented Aug 31, 2023

/backport jdk21u-dev

@openjdk
Copy link

openjdk bot commented Aug 31, 2023

@koppor To use the /backport command, you need to be in the OpenJDK census and your GitHub account needs to be linked with your OpenJDK username (how to associate your GitHub account with your OpenJDK username).

@Siedlerchr
Copy link
Contributor

/backport jdk21u-dev

@openjdk
Copy link

openjdk bot commented Aug 31, 2023

@Siedlerchr To use the /backport command, you need to be in the OpenJDK census and your GitHub account needs to be linked with your OpenJDK username (how to associate your GitHub account with your OpenJDK username).

@Siedlerchr
Copy link
Contributor

@mlchung Could you please do the backport for us? We don't have the rights. Thanks in advance!

@mlchung
Copy link
Member

mlchung commented Sep 1, 2023

sure, I can help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants