-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8315406: [REDO] serviceability/jdwp/AllModulesCommandTest.java ignores VM flags #15499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into |
Webrevs
|
@lmesnik This change is no longer ready for integration - check the PR body for details. |
@@ -107,12 +101,7 @@ public int getJdwpPort() { | |||
|
|||
@Override | |||
public void onStringRead(StreamHandler handler, String line) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
handler
seems unused now as well. There was obviously some kind of grander design for this API that we now seem to be cutting off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submitted #15502
@lmesnik - I have changed the synopsis of this bug since the original fix |
Although the original failure mode only happened in Tier3, because of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a description in the PR or bug that describes the latest
version of this fix. I've read thru the latest changes, but I'm having
trouble putting together a picture.
Test failed because of unexpected output of version string.
The standard convention for tests is to skip any unexpected output (version string, VM warning, vm logging) and only fail on expected error patterns.
Fix is tested by running with default options and with '-showversion' vm option.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15499/head:pull/15499
$ git checkout pull/15499
Update a local copy of the PR:
$ git checkout pull/15499
$ git pull https://git.openjdk.org/jdk.git pull/15499/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15499
View PR using the GUI difftool:
$ git pr show -t 15499
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15499.diff
Webrev
Link to Webrev Comment