Skip to content

8315406: [REDO] serviceability/jdwp/AllModulesCommandTest.java ignores VM flags #15499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

lmesnik
Copy link
Member

@lmesnik lmesnik commented Aug 30, 2023

Test failed because of unexpected output of version string.
The standard convention for tests is to skip any unexpected output (version string, VM warning, vm logging) and only fail on expected error patterns.
Fix is tested by running with default options and with '-showversion' vm option.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315406: [REDO] serviceability/jdwp/AllModulesCommandTest.java ignores VM flags (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15499/head:pull/15499
$ git checkout pull/15499

Update a local copy of the PR:
$ git checkout pull/15499
$ git pull https://git.openjdk.org/jdk.git pull/15499/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15499

View PR using the GUI difftool:
$ git pr show -t 15499

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15499.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 30, 2023

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 30, 2023
@openjdk
Copy link

openjdk bot commented Aug 30, 2023

@lmesnik The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Aug 30, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 30, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 30, 2023

@lmesnik This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 30, 2023
@@ -107,12 +101,7 @@ public int getJdwpPort() {

@Override
public void onStringRead(StreamHandler handler, String line) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handler seems unused now as well. There was obviously some kind of grander design for this API that we now seem to be cutting off.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitted #15502

@dcubed-ojdk
Copy link
Member

@lmesnik - I have changed the synopsis of this bug since the original fix
was [BACKOUT]'ed. This bug and PR is now a [REDO]. Use "/issue JDK-8315406"
to easily update the name.

@dcubed-ojdk
Copy link
Member

Although the original failure mode only happened in Tier3, because of the
broadness of the changes, this PR needs to be run thru more Mach5 Tiers
before being integrated.

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a description in the PR or bug that describes the latest
version of this fix. I've read thru the latest changes, but I'm having
trouble putting together a picture.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Sep 1, 2023
@lmesnik lmesnik marked this pull request as draft September 1, 2023 18:58
@openjdk openjdk bot removed the rfr Pull request is ready for review label Sep 1, 2023
@lmesnik lmesnik changed the title 8315406: serviceability/jdwp/AllModulesCommandTest.java fails after JDK-8314834 8315406: [REDO] serviceability/jdwp/AllModulesCommandTest.java ignores VM flags Sep 1, 2023
@lmesnik lmesnik closed this Sep 1, 2023
@lmesnik lmesnik deleted the 8315406 branch September 1, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

4 participants