Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8202473: A type variable with multiple bounds does not correctly place type annotation #155

Closed
wants to merge 1 commit into from

Conversation

@raphw
Copy link
Member

@raphw raphw commented Sep 14, 2020

This patch assures that an annotation on a type bound is placed on the correct bound index.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8202473: (ann) A type variable with multiple bounds does not correctly place type annotation ⚠️ Title mismatch between PR and JBS.

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/155/head:pull/155
$ git checkout pull/155

@bridgekeeper bridgekeeper bot added the oca label Sep 14, 2020
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 14, 2020

Hi @raphw, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user raphw" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2020

@raphw The following label will be automatically applied to this pull request: core-libs.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the core-libs label Sep 14, 2020
@raphw raphw changed the title A type variable with multiple bounds does not correctly place type annotation 8202473: A type variable with multiple bounds does not correctly place type annotation Sep 14, 2020
@bridgekeeper bridgekeeper bot removed the oca label Sep 15, 2020
@openjdk openjdk bot added the rfr label Sep 15, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 15, 2020

Webrevs

@jbf
Copy link
Member

@jbf jbf commented Sep 15, 2020

/test tier1

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

A test job has been started with id: github.com-149121954-155-692554807

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@jbf your test job with id github.com-149121954-155-692554807 for commits up until 6541a83 has finished.

@jbf
Copy link
Member

@jbf jbf commented Sep 15, 2020

@raphw test is missing imports and doesn't compile, other than that looks good.

@raphw raphw force-pushed the raphw:8202473 branch from 6541a83 to 775b363 Sep 15, 2020
@raphw
Copy link
Member Author

@raphw raphw commented Sep 15, 2020

Bad copy paste. Fixed on the branch.

@raphw
Copy link
Member Author

@raphw raphw commented Sep 15, 2020

/test tier1

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@raphw you need to get approval to run the tests in tier1 for commits up until 775b363

@openjdk openjdk bot added the test-request label Sep 15, 2020
@jbf
Copy link
Member

@jbf jbf commented Sep 15, 2020

/test tier1

@openjdk openjdk bot removed the test-request label Sep 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

A test job has been started with id: github.com-149121954-155-692926028

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@jbf your test job with id github.com-149121954-155-692926028 for commits up until 775b363 has finished.

@jbf
Copy link
Member

@jbf jbf commented Sep 16, 2020

/reviewer add @jbf

@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2020

@jbf Only the author (@raphw) is allowed to issue the reviewer command.

@jbf
Copy link
Member

@jbf jbf commented Sep 16, 2020

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2020

@jbf The change author (@raphw) must issue an integrate command before the integration can be sponsored.

@raphw
Copy link
Member Author

@raphw raphw commented Sep 16, 2020

/reviewer add @jbf

@raphw
Copy link
Member Author

@raphw raphw commented Sep 16, 2020

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2020

@raphw Syntax: /reviewer (credit|remove) [@user | openjdk-user]+. For example:

  • /reviewer credit @openjdk-bot
  • /reviewer credit duke
  • /reviewer credit @user1 @user2
@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2020

@raphw Your merge request cannot be fulfilled at this time, as your changes failed the final jcheck:

  • Too few reviewers with at least role reviewer found (have 0, need at least 1)
@raphw
Copy link
Member Author

@raphw raphw commented Sep 16, 2020

/reviewer credit @jbf

@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2020

@raphw
Reviewer jfranck successfully credited.

@raphw
Copy link
Member Author

@raphw raphw commented Sep 16, 2020

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2020

@raphw Your merge request cannot be fulfilled at this time, as your changes failed the final jcheck:

  • Too few reviewers with at least role reviewer found (have 0, need at least 1)
@jbf
jbf approved these changes Sep 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2020

@raphw This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8202473: A type variable with multiple bounds does not correctly place type annotation

Reviewed-by: jfranck
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 40 commits pushed to the master branch:

  • b87a159: 8252100: NumberOverflow in class MemoryCache
  • 9a7dcdc: 8253261: Disable CDS full module graph until JDK-8253081 is fixed
  • 1c84cfa: 8253130: bug7072653.java failed "Popup window height ... is wrong"
  • ce93cbc: 8253125: vmTestbase/nsk/stress/stack/stack017.java timed out
  • d250f9e: 8253244: Shenandoah: cleanup includes in Shenandoah root processor files
  • d38c97d: 8253207: enable problemlists jcheck's check
  • 671dfba: 6714834: JarFile.getManifest() leaves an open InputStream as an undocumented side effect
  • e5866aa: 8244706: GZIP "OS" header flag hard-coded to 0 instead of 255 (RFC 1952 non-compliance)
  • 1086713: 8253206: Enforce whitespace checking for additional source files
  • e2196f8: 8253162: Make frame::oops_do const
  • ... and 30 more: https://git.openjdk.java.net/jdk/compare/9c24a5635ee4caa81fef2f49c1f323d86ddc02c6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate b87a1599674b8a73f489330decf051d1be9e9fba.

As you do not have Committer status in this projectan existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jbf) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Sep 16, 2020
@raphw
Copy link
Member Author

@raphw raphw commented Sep 16, 2020

/integrate

@openjdk openjdk bot added the sponsor label Sep 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2020

@raphw
Your change (at version 775b363) is now ready to be sponsored by a Committer.

@jbf
Copy link
Member

@jbf jbf commented Sep 17, 2020

/sponsor

@openjdk openjdk bot closed this Sep 17, 2020
@openjdk openjdk bot added integrated and removed sponsor ready rfr labels Sep 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2020

@jbf @raphw Since your change was applied there have been 40 commits pushed to the master branch:

  • b87a159: 8252100: NumberOverflow in class MemoryCache
  • 9a7dcdc: 8253261: Disable CDS full module graph until JDK-8253081 is fixed
  • 1c84cfa: 8253130: bug7072653.java failed "Popup window height ... is wrong"
  • ce93cbc: 8253125: vmTestbase/nsk/stress/stack/stack017.java timed out
  • d250f9e: 8253244: Shenandoah: cleanup includes in Shenandoah root processor files
  • d38c97d: 8253207: enable problemlists jcheck's check
  • 671dfba: 6714834: JarFile.getManifest() leaves an open InputStream as an undocumented side effect
  • e5866aa: 8244706: GZIP "OS" header flag hard-coded to 0 instead of 255 (RFC 1952 non-compliance)
  • 1086713: 8253206: Enforce whitespace checking for additional source files
  • e2196f8: 8253162: Make frame::oops_do const
  • ... and 30 more: https://git.openjdk.java.net/jdk/compare/9c24a5635ee4caa81fef2f49c1f323d86ddc02c6...master

Your commit was automatically rebased without conflicts.

Pushed as commit 53a4ef2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants