8073061: (fs) Files.copy(foo, bar, REPLACE_EXISTING) deletes bar even if foo is not readable

[bplb]

Check that the source is readable before deleting the destination.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8073061: (fs) Files.copy(foo, bar, REPLACE_EXISTING) deletes bar even if foo is not readable (Bug - P4)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15501/head:pull/15501
$ git checkout pull/15501

Update a local copy of the PR:
$ git checkout pull/15501
$ git pull https://git.openjdk.org/jdk.git pull/15501/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15501

View PR using the GUI difftool:
$ git pr show -t 15501

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15501.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 06: Full - Incremental (cd644e46)
• 05: Full - Incremental (8b5f3bcc)
• 04: Full - Incremental (ec6c7ddd)
• 03: Full - Incremental (65009624)
• 02: Full - Incremental (e226096d)
• 01: Full - Incremental (f09b4680)
• 00: Full (a4e0a3bd)

[AlanBateman]

I don't have any other comments, I think you've got this to a good place.

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8073061: (fs) Files.copy(foo, bar, REPLACE_EXISTING) deletes bar even if foo is not readable

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 352 new commits pushed to the master branch:

• 9291b46: 8313804: JDWP support for -Djava.net.preferIPv6Addresses=system
• afa4833: 8271268: Fix Javadoc links for Stream.mapMulti
• 9688ec2: 8311823: JFR: Uninitialized EventEmitter::_thread_id field
• 0f77d25: 8315684: Parallelize sun/security/util/math/TestIntegerModuloP.java
• 311c746: 8316859: RISC-V: Disable detection of V through HWCAP
• 0f0c5b2: 8316648: jrt-fs.jar classes not reproducible between standard and bootcycle builds
• 3d6e775: 8316669: ImmutableOopMapSet destructor not called
• 837783c: 8316670: Remove effectively unused nmethodBucket::_count
• 89e068b: 8316556: Fix typos in java.desktop
• 481cfc7: 8287325: AArch64: fix virtual threads with -XX:UseBranchProtection=pac-ret
• ... and 342 more: https://git.openjdk.org/jdk/compare/dd64a4a483a831fd66912491af10502c4cf8596b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bplb]

/integrate

[openjdk]

Going to push as commit 36ac839.
Since your change was applied there have been 367 commits pushed to the master branch:

• efb7e85: 8316935: [s390x] Use consistent naming for lightweight locking in MacroAssembler
• 4e1e579: 8315920: C2: "control input must dominate current control" assert failure
• 1f7dfda: 8316671: sun/security/ssl/SSLSocketImpl/SSLSocketCloseHang.java test fails intermittent with Read timed out
• 20ff603: 8316735: Print LockStack in hs_err files
• e510dee: 8316098: Revise signature of numa_get_leaf_groups
• 1513e79: 8316940: Serial: Remove unused declarations in genCollectedHeap
• 52983ed: 8303737: C2: Load can bypass subtype check that enforces it's from the right object type
• 9e6cb62: 8316851: Add @sealedGraph to Executable
• 3fe6e0f: 8308479: [s390x] Implement alternative fast-locking scheme
• e2e8e8e: 8312136: Modify runtime/ErrorHandling/TestDwarf.java to split dwarf and decoder testing
• ... and 357 more: https://git.openjdk.org/jdk/compare/dd64a4a483a831fd66912491af10502c4cf8596b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit 36ac839.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.