8315437: Enable parallelism in vmTestbase/nsk/monitoring/stress/classload tests

[shipilev]

Current vmTestbase/nsk/monitoring/stress/classload tests contains 24 tests, each running exclusively. This drags the tier4 test times up. There seem to be no reason to run these tests exclusively, though: they complete in reasonable time, are lightly-threaded, and consume the usual amount of memory.

We should consider enabling parallelism for them and get improved test performance. Currently it is blocked by TEST.properties with exclusiveAccess.dirs directives in them.

Current run on 18-core machine:
2011.95s user 201.83s system 356% cpu 10:20.19 total

Fully parallel:
2274.02s user 128.64s system 2029% cpu 1:58.39 total

Additional testing:

• 50x iterations of Linux x86_64 fastdebug vmTestbase/nsk/monitoring/stress/classload

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8315437: Enable parallelism in vmTestbase/nsk/monitoring/stress/classload tests (Enhancement - P4)

Reviewers

• Leonid Mesnik (@lmesnik - Reviewer)
• Chris Plummer (@plummercj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15506/head:pull/15506
$ git checkout pull/15506

Update a local copy of the PR:
$ git checkout pull/15506
$ git pull https://git.openjdk.org/jdk.git pull/15506/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15506

View PR using the GUI difftool:
$ git pr show -t 15506

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15506.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (569c454e)

[sspitsyn]

The fix looks okay to me but it'd be nice to find out why the exclusiveAccess.dirs were set for these tests initially. I'm not sure, anyone remembers it though.

[shipilev]

The fix looks okay to me but it'd be nice to find out why the exclusiveAccess.dirs were set for these tests initially. I'm not sure, anyone remembers it though.

Yeah. I cannot find a good discussion on these tests.

I suspect it is mostly historical, from the times where machines were small and resource-constrained, so that a stress test made life hard for any other concurrently running test. Today, that is not the case. We have been doing e.g. GC stress tests in tier3, which can hog CPUs for minutes, without ill effects.

Anyway, this is similar to other parallelism improvements we did over the previous years, e.g. https://bugs.openjdk.org/browse/JDK-8273433, https://bugs.openjdk.org/browse/JDK-8273438.

Would you like to run this PR in your test systems to see if this particular relaxation is problematic?

[shipilev]

@lmesnik, may I interest you in this one too?

[lmesnik]

Looks good, CI passed.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315437: Enable parallelism in vmTestbase/nsk/monitoring/stress/classload tests

Reviewed-by: lmesnik, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 146 new commits pushed to the master branch:

• d06a564: 8315765: G1: Incorrect use of G1LastPLABAverageOccupancy
• 66b6a5a: 8277954: Replace use of monitors with explicit locks in the JDK LDAP provider implementation
• 4cb4637: 8315970: Big-endian issues after JDK-8310929
• ae08143: 8315611: Open source swing text/html and tree test
• 7b3e697: 8315855: G1: Revise signature of set_humongous_candidate
• 1941290: 8315942: Sort platform enums and definitions after JDK-8304913 follow-ups
• 996b336: 8315781: Reduce the max value of GCDrainStackTargetSize
• 35bccac: 8315841: RISC-V: Check for hardware TSO support
• a04c6c1: 8315609: Open source few more swing text/html tests
• dab1c21: 8314491: Linux: jexec launched via PATH fails to find java
• ... and 136 more: https://git.openjdk.org/jdk/compare/ed1ea5fe7c6fad03ca96e7dece2127eab21a608a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Good, any other reviewers for this one? Thanks!

[shipilev]

Good, any other reviewers for this one? Thanks!

Ping? Thanks!

[shipilev]

Thanks!

/integrate

[openjdk]

Going to push as commit dd214d0.
Since your change was applied there have been 147 commits pushed to the master branch:

• 877731d: 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies
• d06a564: 8315765: G1: Incorrect use of G1LastPLABAverageOccupancy
• 66b6a5a: 8277954: Replace use of monitors with explicit locks in the JDK LDAP provider implementation
• 4cb4637: 8315970: Big-endian issues after JDK-8310929
• ae08143: 8315611: Open source swing text/html and tree test
• 7b3e697: 8315855: G1: Revise signature of set_humongous_candidate
• 1941290: 8315942: Sort platform enums and definitions after JDK-8304913 follow-ups
• 996b336: 8315781: Reduce the max value of GCDrainStackTargetSize
• 35bccac: 8315841: RISC-V: Check for hardware TSO support
• a04c6c1: 8315609: Open source few more swing text/html tests
• ... and 137 more: https://git.openjdk.org/jdk/compare/ed1ea5fe7c6fad03ca96e7dece2127eab21a608a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit dd214d0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.