Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257434: jpackage fails to create rpm on Fedora Linux #1551

Closed

Conversation

alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Dec 1, 2020

Add missing quotes to %if expressions in spec template. Required by rpmbuild 4.16.0


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257434: jpackage fails to create rpm on Fedora Linux

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1551/head:pull/1551
$ git checkout pull/1551

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 1, 2020

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 1, 2020

@alexeysemenyukoracle To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 2, 2020
@alexeysemenyukoracle
Copy link
Member Author

alexeysemenyukoracle commented Dec 2, 2020

@sashamatveev @andyherrick please review

Copy link

@andyherrick andyherrick left a comment

looks good

@openjdk
Copy link

openjdk bot commented Dec 2, 2020

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257434: jpackage fails to create rpm on Fedora Linux

Reviewed-by: almatvee, herrick

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 03f3b8e: 8210253: Clipped UI rendering with X11 pipeline and HiDPI
  • ce496cb: 8257190: simplify PhaseIdealLoop constructors

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 2, 2020
@alexeysemenyukoracle
Copy link
Member Author

alexeysemenyukoracle commented Dec 2, 2020

/integrate

@openjdk openjdk bot closed this Dec 2, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 2, 2020
@openjdk
Copy link

openjdk bot commented Dec 2, 2020

@alexeysemenyukoracle Since your change was applied there have been 4 commits pushed to the master branch:

  • 8f4fa3f: 8257232: CompileThresholdScaling fails to work on 32-bit platforms
  • cfd070e: 8257537: [vector] Cleanup redundant bitwise cases on floating point vectors
  • 03f3b8e: 8210253: Clipped UI rendering with X11 pipeline and HiDPI
  • ce496cb: 8257190: simplify PhaseIdealLoop constructors

Your commit was automatically rebased without conflicts.

Pushed as commit 541c7f7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@alexeysemenyukoracle alexeysemenyukoracle deleted the JDK-8257434 branch Jan 18, 2022
@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 18, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 18, 2022

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants