JDK-8315445: 8314748 causes crashes in x64 builds

[theRealAph]

The crash happens during this phase:
[2023-08-31T08:51:27,258Z] Optimizing the exploded image

This is the failure mode:

# Internal Error (src/hotspot/cpu/x86/macroAssembler_x86.cpp:2755), pid=20045, tid=20157
# assert(rscratch != noreg || always_reachable(src)) failed: missing
#
# JRE version: OpenJDK Runtime Environment (22.0+14) (fastdebug build 22-ea+14-963)
# Java VM: OpenJDK 64-Bit Server VM (fastdebug 22-ea+14-963, mixed mode, tiered, compressed oops, compressed class ptrs, g1 gc, linux-amd64)
# Problematic frame:
# V [libjvm.so+0x12f17b9] MacroAssembler::evmovdquq(XMMRegister, AddressLiteral, int, Register)+0x1a9

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8315445: 8314748 causes crashes in x64 builds (Bug - P1)

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15512/head:pull/15512
$ git checkout pull/15512

Update a local copy of the PR:
$ git checkout pull/15512
$ git pull https://git.openjdk.org/jdk.git pull/15512/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15512

View PR using the GUI difftool:
$ git pr show -t 15512

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15512.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@theRealAph The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (423448c6)

[chhagedorn]

I've totally missed that it in the review - thanks for fixing it quickly! Looks good and trivial.

[openjdk]

@theRealAph This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315445: 8314748 causes crashes in x64 builds

Reviewed-by: chagedorn, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 145d8bc: 8315051: jdk/jfr/jvm/TestGetEventWriter.java fails with non-JVMCI GCs

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[theRealAph]

I've totally missed that it in the review - thanks for fixing it quickly! Looks good and trivial.

It was very hard to spot. Default arguments [sometimes] considered harmful.

8314748 is only going to fail with certain memory layouts, and I can't reproduce that. Should I wait for all the auto-tests to complete, or just push, on the grounds that it's not going to make things any worse?

[chhagedorn]

It was very hard to spot. Default arguments [sometimes] considered harmful.

Indeed!

I've run a quick sanity tier1 testing which just finished and looked good. So, I guess this is good to go as the original testing before the additional clean-up looked good.

[theRealAph]

/integrate

[openjdk]

Going to push as commit 29ff1e4.
Since your change was applied there has been 1 commit pushed to the master branch:

• 145d8bc: 8315051: jdk/jfr/jvm/TestGetEventWriter.java fails with non-JVMCI GCs

Your commit was automatically rebased without conflicts.

[openjdk]

@theRealAph Pushed as commit 29ff1e4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.