-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8313983: jmod create --target-platform should replace existing ModuleTarget attribute #15514
Conversation
👋 Welcome back asotona! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this.
@asotona This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Would you consider documenting in the javadoc of XXXAttribute in the ClassFile API if it allows multiple? It will make clear to the readers. |
Yes, I'll add that information as a part of javadoc update #14968. |
/integrate |
Going to push as commit c2e01eb.
Your commit was automatically rebased without conflicts. |
ModuleTarget and ModuleResolution attributes were flagged as 'allow multiple' in the Classfile API.
This patch removed the flags and allows at most one instance of each attribute.
Please review.
Thanks,
Adam
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15514/head:pull/15514
$ git checkout pull/15514
Update a local copy of the PR:
$ git checkout pull/15514
$ git pull https://git.openjdk.org/jdk.git pull/15514/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15514
View PR using the GUI difftool:
$ git pr show -t 15514
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15514.diff
Webrev
Link to Webrev Comment