Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314632: Intra-case dominance check fails in the presence of a guard #15515

Closed
wants to merge 3 commits into from

Conversation

biboudis
Copy link
Member

@biboudis biboudis commented Aug 31, 2023

Intra-case domination should be affected by the presence of a guard. A missing check in dominance ensures that requirement.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314632: Intra-case dominance check fails in the presence of a guard (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15515/head:pull/15515
$ git checkout pull/15515

Update a local copy of the PR:
$ git checkout pull/15515
$ git pull https://git.openjdk.org/jdk.git pull/15515/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15515

View PR using the GUI difftool:
$ git pr show -t 15515

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15515.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 31, 2023

👋 Welcome back abimpoudis! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 31, 2023
@openjdk
Copy link

openjdk bot commented Aug 31, 2023

@biboudis The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Aug 31, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 31, 2023

Webrevs

Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@openjdk
Copy link

openjdk bot commented Aug 31, 2023

@biboudis This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314632: Intra-case dominance check fails in the presence of a guard

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

  • 0d52c82: 8310220: IGV: dump graph after each IGVN step at level 4
  • adfc1d6: 8313323: javac -g on a java file which uses unnamed variable leads to ClassFormatError when launching that class
  • 2dc930d: 8314997: Missing optimization opportunities due to missing try_clean_mem_phi() calls
  • ab12c5d: 8315549: CITime misreports code/total nmethod sizes
  • ba8d5c2: 8315582: Exclude compiler/codecache/CodeCacheFullCountTest.java with Xcomp
  • 75d4ac2: 8311775: [TEST] duplicate verifyHeapDump in several tests
  • 4f90aba: 8311585: Add JRadioButtonMenuItem to bug8031573.java
  • 2a11bc4: 8314837: 5 compiled/codecache tests ignore VM flags
  • 2f7c65e: 8303427: Fixpath confused if unix root contains "/jdk"
  • e9e0c56: 8314319: LogCompilation doesn't reset lateInlining when it encounters a failure.
  • ... and 21 more: https://git.openjdk.org/jdk/compare/145d8bc1a3ef4f4fe0c10385be111838e7ed9250...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vicente-romero-oracle, @lahodaj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 31, 2023
Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good to me, but please see the inline comment. Thanks!

test/langtools/tools/javac/patterns/T8314632.java Outdated Show resolved Hide resolved
@biboudis
Copy link
Member Author

biboudis commented Sep 4, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 4, 2023
@openjdk
Copy link

openjdk bot commented Sep 4, 2023

@biboudis
Your change (at version 8e8de82) is now ready to be sponsored by a Committer.

@lahodaj
Copy link
Contributor

lahodaj commented Sep 7, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 7, 2023

Going to push as commit 81f8c57.
Since your change was applied there have been 78 commits pushed to the master branch:

  • b408a82: 8314260: Unable to load system libraries on Windows when using a SecurityManager
  • 726c9c9: 8315735: VerifyError when switch statement used with synchronized block
  • fd6442c: 8315602: Open source swing security manager test
  • e22eb06: 8315651: Stop hiding AIX specific multicast socket errors via NetworkConfiguration (aix)
  • 9887cd8: 8315751: RandomTestBsi1999 fails often with timeouts on Linux ppc64le
  • 8107eab: 8314121: test tools/jpackage/share/RuntimePackageTest.java#id0 fails on RHEL8
  • ab28300: 8315698: Crash when comparing BasicType as int after JDK-8310577
  • b05198a: 8315600: Open source few more headless Swing misc tests
  • 4127fbb: 8315606: Open source few swing text/html tests
  • 9402548: 8268719: Force execution (and source) code page used when compiling on Windows
  • ... and 68 more: https://git.openjdk.org/jdk/compare/145d8bc1a3ef4f4fe0c10385be111838e7ed9250...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 7, 2023
@openjdk openjdk bot closed this Sep 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 7, 2023
@openjdk
Copy link

openjdk bot commented Sep 7, 2023

@lahodaj @biboudis Pushed as commit 81f8c57.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@biboudis
Copy link
Member Author

/backport jdk21u

@openjdk
Copy link

openjdk bot commented Sep 15, 2023

@biboudis the backport was successfully created on the branch biboudis-backport-81f8c57e in my personal fork of openjdk/jdk21u. To create a pull request with this backport targeting openjdk/jdk21u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 81f8c57e from the openjdk/jdk repository.

The commit being backported was authored by Aggelos Biboudis on 7 Sep 2023 and was reviewed by Vicente Romero.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u:

$ git fetch https://github.com/openjdk-bots/jdk21u.git biboudis-backport-81f8c57e:biboudis-backport-81f8c57e
$ git checkout biboudis-backport-81f8c57e
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u.git biboudis-backport-81f8c57e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants