Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8315459: Print G1 reserved and committed sizes as separate items in VM.info and hs_err #15516

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Aug 31, 2023

Trivial printing change.

Heap:
 garbage-first heap total 1040384K, used 4985K [0x0000000414000000, 0x0000000800000000)

We print the committed heap size as "total". Reserved size is missing and can only be deduced using the following address range size. And the apparent mismatch between that range size and the printed "total" value also confused some customers.

Let's print the reserved and committed total separately:

Heap:
 garbage-first heap   total reserved 16449536K, committed 1040384K, used 4985K [0x0000000414000000, 0x0000000800000000)

Tests: I ran serviceability/sa/TestUniverse.java, which was the only test I could find that parsed this output. GHAs also ran successfully (not sure why they are marked as still running, though, they are long finished).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315459: Print G1 reserved and committed sizes as separate items in VM.info and hs_err (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15516/head:pull/15516
$ git checkout pull/15516

Update a local copy of the PR:
$ git checkout pull/15516
$ git pull https://git.openjdk.org/jdk.git pull/15516/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15516

View PR using the GUI difftool:
$ git pr show -t 15516

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15516.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 31, 2023

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 31, 2023

@tstuefe The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Aug 31, 2023
@tstuefe tstuefe force-pushed the JDK-8315459-Print-G1-reserved-and-committed-sizes-as-separate-items-in-VM.info-and-hs_err branch from 1d4fe38 to b8ca412 Compare August 31, 2023 13:02
@tstuefe tstuefe marked this pull request as ready for review August 31, 2023 17:33
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 31, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 31, 2023

Webrevs

Copy link
Member

@albertnetymk albertnetymk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using %zu instead of SIZE_FORMAT probably makes it easier to read.

@openjdk
Copy link

openjdk bot commented Aug 31, 2023

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315459: Print G1 reserved and committed sizes as separate items in VM.info and hs_err

Reviewed-by: ayang, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 764f65c: 8315278: Patch 'print-targets' target to print targets separated by new line
  • 7754ac0: 8314925: ChoiceFormat does not specify IllegalArgumentExceptions
  • 2264667: 8315422: getSoTimeout() would be in try block in SSLSocketImpl
  • d5973bd: 6333341: [BI] Doc: java.text.BreakIterator class specification is unclear
  • 63f561f: 8306882: (fs) Path.toRealPath(LinkOption.NOFOLLOW_LINKS) fails when "../../" follows a link
  • 2436fb0: 8312306: Add more Reference.reachabilityFence() calls to the security classes using Cleaner
  • 351c31e: 8315378: [BACKOUT] runtime/NMT/SummarySanityCheck.java failed with "Total committed (MMMMMM) did not match the summarized committed (NNNNNN)"
  • c12ca88: 8312521: Unused field LocaleProviderAdapter#defaultLocaleProviderAdapter could be removed
  • b38bcae: 8313656: assert(!JvmtiExport::can_support_virtual_threads()) with -XX:-DoJVMTIVirtualThreadTransitions
  • c8acab1: 8315413: Remove special filtering of Continuation.yield0 in StackWalker
  • ... and 2 more: https://git.openjdk.org/jdk/compare/145d8bc1a3ef4f4fe0c10385be111838e7ed9250...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 31, 2023
@tstuefe
Copy link
Member Author

tstuefe commented Aug 31, 2023

Using %zu instead of SIZE_FORMAT probably makes it easier to read.

Good point. I keep forgetting that exists.

@tstuefe
Copy link
Member Author

tstuefe commented Sep 1, 2023

Thanks @albertnetymk and @tschatzl

/integrate

@openjdk
Copy link

openjdk bot commented Sep 1, 2023

Going to push as commit 81b5d22.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 764f65c: 8315278: Patch 'print-targets' target to print targets separated by new line
  • 7754ac0: 8314925: ChoiceFormat does not specify IllegalArgumentExceptions
  • 2264667: 8315422: getSoTimeout() would be in try block in SSLSocketImpl
  • d5973bd: 6333341: [BI] Doc: java.text.BreakIterator class specification is unclear
  • 63f561f: 8306882: (fs) Path.toRealPath(LinkOption.NOFOLLOW_LINKS) fails when "../../" follows a link
  • 2436fb0: 8312306: Add more Reference.reachabilityFence() calls to the security classes using Cleaner
  • 351c31e: 8315378: [BACKOUT] runtime/NMT/SummarySanityCheck.java failed with "Total committed (MMMMMM) did not match the summarized committed (NNNNNN)"
  • c12ca88: 8312521: Unused field LocaleProviderAdapter#defaultLocaleProviderAdapter could be removed
  • b38bcae: 8313656: assert(!JvmtiExport::can_support_virtual_threads()) with -XX:-DoJVMTIVirtualThreadTransitions
  • c8acab1: 8315413: Remove special filtering of Continuation.yield0 in StackWalker
  • ... and 2 more: https://git.openjdk.org/jdk/compare/145d8bc1a3ef4f4fe0c10385be111838e7ed9250...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 1, 2023
@openjdk openjdk bot closed this Sep 1, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 1, 2023
@openjdk
Copy link

openjdk bot commented Sep 1, 2023

@tstuefe Pushed as commit 81b5d22.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants