Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313575: Refactor PKCS11Test tests #15523

Closed
wants to merge 1 commit into from
Closed

8313575: Refactor PKCS11Test tests #15523

wants to merge 1 commit into from

Conversation

rhalade
Copy link
Member

@rhalade rhalade commented Aug 31, 2023

PKCS11Test is updated to remove testDefault and testDeimos. Sun Crypto Accelerator is not supported now and there is no default PKCS11 provider with default JDK configuration.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313575: Refactor PKCS11Test tests (Enhancement - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15523/head:pull/15523
$ git checkout pull/15523

Update a local copy of the PR:
$ git checkout pull/15523
$ git pull https://git.openjdk.org/jdk.git pull/15523/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15523

View PR using the GUI difftool:
$ git pr show -t 15523

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15523.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 31, 2023

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 31, 2023
@openjdk
Copy link

openjdk bot commented Aug 31, 2023

@rhalade The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Aug 31, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 31, 2023

Webrevs

Copy link
Contributor

@valeriepeng valeriepeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@openjdk
Copy link

openjdk bot commented Sep 5, 2023

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313575: Refactor PKCS11Test tests

Reviewed-by: valeriep

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 52 new commits pushed to the master branch:

  • d3ee704: 8315563: Remove references to JDK-8226420 from problem list
  • aba89f2: 8312213: Remove unnecessary TEST instructions on x86 when flags reg will already be set
  • 1f4cdb3: 8315127: CDSMapTest fails with incorrect number of oop references
  • 939d7c5: 8161536: sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java fails with ProviderException
  • ebe3127: 8315717: ProblemList serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC
  • 969fcdb: 8314191: C2 compilation fails with "bad AD file"
  • cef9fff: 8305507: Add support for grace period before AbortVMOnSafepointTimeout triggers
  • ed2b467: 8315499: build using devkit on Linux ppc64le RHEL puts path to devkit into libsplashscreen
  • 4b44575: 8305637: Remove Opaque1 nodes for Parse Predicates and clean up useless predicate elimination
  • 8647f00: 8293850: need a largest_committed metric for each category of NMT's output
  • ... and 42 more: https://git.openjdk.org/jdk/compare/c8acab1d913a6c676706fce7ad98a7f831a95682...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 5, 2023
@rhalade
Copy link
Member Author

rhalade commented Sep 5, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Sep 5, 2023

Going to push as commit 7a08e6b.
Since your change was applied there have been 52 commits pushed to the master branch:

  • d3ee704: 8315563: Remove references to JDK-8226420 from problem list
  • aba89f2: 8312213: Remove unnecessary TEST instructions on x86 when flags reg will already be set
  • 1f4cdb3: 8315127: CDSMapTest fails with incorrect number of oop references
  • 939d7c5: 8161536: sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java fails with ProviderException
  • ebe3127: 8315717: ProblemList serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC
  • 969fcdb: 8314191: C2 compilation fails with "bad AD file"
  • cef9fff: 8305507: Add support for grace period before AbortVMOnSafepointTimeout triggers
  • ed2b467: 8315499: build using devkit on Linux ppc64le RHEL puts path to devkit into libsplashscreen
  • 4b44575: 8305637: Remove Opaque1 nodes for Parse Predicates and clean up useless predicate elimination
  • 8647f00: 8293850: need a largest_committed metric for each category of NMT's output
  • ... and 42 more: https://git.openjdk.org/jdk/compare/c8acab1d913a6c676706fce7ad98a7f831a95682...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 5, 2023
@openjdk openjdk bot closed this Sep 5, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 5, 2023
@openjdk
Copy link

openjdk bot commented Sep 5, 2023

@rhalade Pushed as commit 7a08e6b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@rhalade rhalade deleted the 8313575-pkcs11 branch September 5, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants