8315534: Incorrect warnings about implicit annotation processing

[lahodaj]

When the API client sets annotation processors using CompilationTask.setProcessors and then uses JavacTask to drive the compiler using the analyze() method, the compiler.note.implicit.annotation.processing note is printed even though the annotation processing is explicit.

This patch is attempting to solve that by marking all processing with explicit processors as explicit.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8315534: Incorrect warnings about implicit annotation processing (Bug - P3)

Reviewers

• Joe Darcy (@jddarcy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15540/head:pull/15540
$ git checkout pull/15540

Update a local copy of the PR:
$ git checkout pull/15540
$ git pull https://git.openjdk.org/jdk.git pull/15540/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15540

View PR using the GUI difftool:
$ git pr show -t 15540

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15540.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lahodaj The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (685b1e46)

[jddarcy]

Thanks for fixing this @lahodaj ; looks fine. I think this issue would be good to backport to 21u as well.

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315534: Incorrect warnings about implicit annotation processing

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

• 56b8db1: 8258970: Disabled JPasswordField foreground color is wrong with GTK LAF
• 0d4cadb: 8315195: RISC-V: Update hwprobe query for new extensions
• b4f7069: 8315446: G1: Remove unused G1AllocRegion::attempt_allocation
• cf02cf3: 8315098: Improve URLEncodeDecode microbenchmark
• c32e340: 8315321: [aix] os::attempt_reserve_memory_at must map at the requested address or fail
• 42f5b9e: 8315436: HttpsServer does not send TLS alerts
• 033f311: 8315069: Relativize extended_sp in interpreter frames
• c2e01eb: 8313983: jmod create --target-platform should replace existing ModuleTarget attribute
• 81b5d22: 8315459: Print G1 reserved and committed sizes as separate items in VM.info and hs_err
• 764f65c: 8315278: Patch 'print-targets' target to print targets separated by new line
• ... and 32 more: https://git.openjdk.org/jdk/compare/cb3f9680d35f2afbd973c946ad4ccf94f30fffc9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lahodaj]

/integrate

[lahodaj]

/backport jdk21u

[openjdk]

Going to push as commit 94a74a0.
Since your change was applied there have been 54 commits pushed to the master branch:

• 84425a6: 8315452: Erroneous AST missing modifiers for partial input
• 3094fd1: 8314662: jshell shows duplicated signatures of javap
• 0d52c82: 8310220: IGV: dump graph after each IGVN step at level 4
• adfc1d6: 8313323: javac -g on a java file which uses unnamed variable leads to ClassFormatError when launching that class
• 2dc930d: 8314997: Missing optimization opportunities due to missing try_clean_mem_phi() calls
• ab12c5d: 8315549: CITime misreports code/total nmethod sizes
• ba8d5c2: 8315582: Exclude compiler/codecache/CodeCacheFullCountTest.java with Xcomp
• 75d4ac2: 8311775: [TEST] duplicate verifyHeapDump in several tests
• 4f90aba: 8311585: Add JRadioButtonMenuItem to bug8031573.java
• 2a11bc4: 8314837: 5 compiled/codecache tests ignore VM flags
• ... and 44 more: https://git.openjdk.org/jdk/compare/cb3f9680d35f2afbd973c946ad4ccf94f30fffc9...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lahodaj Pushed as commit 94a74a0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[openjdk]

@lahodaj the backport was successfully created on the branch lahodaj-backport-94a74a0a in my personal fork of openjdk/jdk21u. To create a pull request with this backport targeting openjdk/jdk21u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 94a74a0a from the openjdk/jdk repository.

The commit being backported was authored by Jan Lahoda on 4 Sep 2023 and was reviewed by Joe Darcy.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u:

$ git fetch https://github.com/openjdk-bots/jdk21u.git lahodaj-backport-94a74a0a:lahodaj-backport-94a74a0a
$ git checkout lahodaj-backport-94a74a0a
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u.git lahodaj-backport-94a74a0a