Skip to content

8315369: [JVMCI] failure to attach to a libgraal isolate during shutdown should not be fatal #15542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

8315369: [JVMCI] failure to attach to a libgraal isolate during shutdown should not be fatal #15542

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3634bd6
make caller handle error in JVMCIEnv constructor
dougxc Sep 1, 2023
66ff8bf
convert assert to guarantee
dougxc Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hotspot/share/jvmci/jniAccessMark.inline.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class JNIAccessMark : public StackObj {
inline JNIAccessMark(JVMCIEnv* jvmci_env, JavaThread* thread=JavaThread::current()) :
_ttnfv(thread), _hm(thread) {
_env = jvmci_env->_env;
assert(jvmci_env->init_error() == JNI_OK, "invalid JVMCIEnv (err: %d)", jvmci_env->init_error());
guarantee(jvmci_env->init_error() == JNI_OK, "invalid JVMCIEnv (err: %d)", jvmci_env->init_error());
}
JNIEnv* env() const { return _env; }
JNIEnv* operator () () const { return _env; }
Expand Down