8315406: [REDO] serviceability/jdwp/AllModulesCommandTest.java ignores VM flags

[lmesnik]

The fix changes test serviceability/jdwp/AllModulesCommandTest.java to accept VM flags.

1. The 'ProcessTools.createTestJvm(JDWP_OPT, DEBUGGEE);' is used to start debugee
2. The stderr is just logging and tests doesn't check if it is empty. stderr might contain some VM output which doesn't mean failure
3. Some refactoring is done. Method ' public void onStringRead(StreamHandler handler, String line) {' doesn't need to check which handler is used and corresponding code and methods are deleted. The field 'inputHandler' and 'errorHandler' were moved into method.

Tested with tier1-5 to ensure that test correctly work with CI options.

The serviceability/jdwp/AllModulesCommandTest.java is the only one test in serviceability/jdwp directory so no other tests should be affected.

I closed my previous PR #15499 because GitHub incorrectly show changes after merge with backout if the first fix.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8315406: [REDO] serviceability/jdwp/AllModulesCommandTest.java ignores VM flags (Bug - P2)

Reviewers

• Chris Plummer (@plummercj - Reviewer)
• Daniel D. Daugherty (@dcubed-ojdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15544/head:pull/15544
$ git checkout pull/15544

Update a local copy of the PR:
$ git checkout pull/15544
$ git pull https://git.openjdk.org/jdk.git pull/15544/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15544

View PR using the GUI difftool:
$ git pr show -t 15544

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15544.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lmesnik The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (9ff97c52)
• 01: Full - Incremental (721a719c)
• 00: Full (550be2ab)

[openjdk]

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315406: [REDO] serviceability/jdwp/AllModulesCommandTest.java ignores VM flags

Reviewed-by: cjplummer, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

• 1f4cdb3: 8315127: CDSMapTest fails with incorrect number of oop references
• 939d7c5: 8161536: sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java fails with ProviderException
• ebe3127: 8315717: ProblemList serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC
• 969fcdb: 8314191: C2 compilation fails with "bad AD file"
• cef9fff: 8305507: Add support for grace period before AbortVMOnSafepointTimeout triggers
• ed2b467: 8315499: build using devkit on Linux ppc64le RHEL puts path to devkit into libsplashscreen
• 4b44575: 8305637: Remove Opaque1 nodes for Parse Predicates and clean up useless predicate elimination
• 8647f00: 8293850: need a largest_committed metric for each category of NMT's output
• 5a2e151: 8315548: G1: Document why VM_G1CollectForAllocation::doit() may allocate without completing a GC
• 9013b03: 8315442: Enable parallelism in vmTestbase/nsk/monitoring/stress/thread tests
• ... and 20 more: https://git.openjdk.org/jdk/compare/2f7c65ec48dc35d75eed8af411d482ba40de70dc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dcubed-ojdk]

Thanks for creating a new (and more clear) PR. Also thanks for adding
the updated description of this changes.

Thumbs. up.

[lmesnik]

/integrate

[openjdk]

Going to push as commit 5cbff24.
Since your change was applied there have been 33 commits pushed to the master branch:

• 7a08e6b: 8313575: Refactor PKCS11Test tests
• d3ee704: 8315563: Remove references to JDK-8226420 from problem list
• aba89f2: 8312213: Remove unnecessary TEST instructions on x86 when flags reg will already be set
• 1f4cdb3: 8315127: CDSMapTest fails with incorrect number of oop references
• 939d7c5: 8161536: sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java fails with ProviderException
• ebe3127: 8315717: ProblemList serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC
• 969fcdb: 8314191: C2 compilation fails with "bad AD file"
• cef9fff: 8305507: Add support for grace period before AbortVMOnSafepointTimeout triggers
• ed2b467: 8315499: build using devkit on Linux ppc64le RHEL puts path to devkit into libsplashscreen
• 4b44575: 8305637: Remove Opaque1 nodes for Parse Predicates and clean up useless predicate elimination
• ... and 23 more: https://git.openjdk.org/jdk/compare/2f7c65ec48dc35d75eed8af411d482ba40de70dc...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lmesnik Pushed as commit 5cbff24.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.