8286757: adlc tries to build with /pathmap but without /experimental:deterministic

[erikj79]

Compiling the ADLC build tool on Windows is generating multiple warnings like this:

cl : Command line warning D9007 : '/pathmap:' requires '/experimental:deterministic'; option ignored

This is caused by the ADLC_CFLAGS are including $FILE_MACRO_CFLAGS but missing $REPRODUCIBLE_CFLAGS. This patch simply adds them. At some point we should refactor the ADLC flags properly, but I don't think we should wait for that to fix these warnings.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8286757: adlc tries to build with /pathmap but without /experimental:deterministic (Bug - P3)

Reviewers

• Julian Waters (@TheShermanTanker - Committer)
• Magnus Ihse Bursie (@magicus - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15545/head:pull/15545
$ git checkout pull/15545

Update a local copy of the PR:
$ git checkout pull/15545
$ git pull https://git.openjdk.org/jdk.git pull/15545/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15545

View PR using the GUI difftool:
$ git pr show -t 15545

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15545.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@erikj79 The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e4da39a2)

[TheShermanTanker]

I'll add cleaning up the ADLC flags to my list of things to do. It's a shame that we can't add the deterministic setting to ADLC_CFLAGS without exporting it to spec.gmk.in though, in my opinion. In any case, have a complementary approval :)

[magicus]

Looks good. I agree that ADLC flags needs to be sorted out properly at some time...

[openjdk]

@erikj79 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286757: adlc tries to build with /pathmap but without /experimental:deterministic

Reviewed-by: jwaters, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 238 new commits pushed to the master branch:

• e1870d3: 8316411: compiler/compilercontrol/TestConflictInlineCommands.java fails intermittent with force inline by CompileCommand missing
• ec74194: 8316546: Backout JDK-8315932: runtime/InvocationTests spend a lot of time on dependency verification
• 2568188: 8316547: Use JUnit.dir jtreg property with jpackage JUnit tests
• 833a828: 8315876: Open source several Swing CSS related tests
• 7ce5bd1: 8316468: os::write incorrectly handles partial write
• d19e017: 8315951: Open source several Swing HTMLEditorKit related tests
• 62c0a1b: 8315883: Open source several Swing JToolbar tests
• 0c97246: 8311113: Remove invalid pointer cast and clean up setLabel() in awt_MenuItem.cpp
• d2b2f67: 8315952: Open source several Swing JToolbar JTooltip JTree tests
• 5f6cee8: 8316056: Open source several Swing JTree tests
• ... and 228 more: https://git.openjdk.org/jdk/compare/2f7c65ec48dc35d75eed8af411d482ba40de70dc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[erikj79]

/integrate

[openjdk]

Going to push as commit 242eeae.
Since your change was applied there have been 239 commits pushed to the master branch:

• b275bdd: 8308995: Update Network IO JFR events to be static mirror events
• e1870d3: 8316411: compiler/compilercontrol/TestConflictInlineCommands.java fails intermittent with force inline by CompileCommand missing
• ec74194: 8316546: Backout JDK-8315932: runtime/InvocationTests spend a lot of time on dependency verification
• 2568188: 8316547: Use JUnit.dir jtreg property with jpackage JUnit tests
• 833a828: 8315876: Open source several Swing CSS related tests
• 7ce5bd1: 8316468: os::write incorrectly handles partial write
• d19e017: 8315951: Open source several Swing HTMLEditorKit related tests
• 62c0a1b: 8315883: Open source several Swing JToolbar tests
• 0c97246: 8311113: Remove invalid pointer cast and clean up setLabel() in awt_MenuItem.cpp
• d2b2f67: 8315952: Open source several Swing JToolbar JTooltip JTree tests
• ... and 229 more: https://git.openjdk.org/jdk/compare/2f7c65ec48dc35d75eed8af411d482ba40de70dc...master

Your commit was automatically rebased without conflicts.

[openjdk]

@erikj79 Pushed as commit 242eeae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.