Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8226420: sun/tools/jstatd tests failed with Port already in use #15546

Closed
wants to merge 1 commit into from

Conversation

alexmenkov
Copy link

@alexmenkov alexmenkov commented Sep 1, 2023

Logic to detect "port in use" case and retry was implemented in the test by JDK-8240711.
Infra issue with some test host when system software listened on port 1099 was resolved long time ago.

So JDK-8226420 has been closed as a duplicate.
The fix removes references to 8226420 from problemlist (the tests remain problemlisted due other issues).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8226420: sun/tools/jstatd tests failed with Port already in use (Bug - P4) ⚠️ Issue is not open.
  • JDK-8315563: Remove references to JDK-8226420 from problem list (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15546/head:pull/15546
$ git checkout pull/15546

Update a local copy of the PR:
$ git checkout pull/15546
$ git pull https://git.openjdk.org/jdk.git pull/15546/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15546

View PR using the GUI difftool:
$ git pr show -t 15546

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15546.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 1, 2023

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 1, 2023
@openjdk
Copy link

openjdk bot commented Sep 1, 2023

@alexmenkov To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@plummercj
Copy link
Contributor

/label serviceability

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Sep 1, 2023
@openjdk
Copy link

openjdk bot commented Sep 1, 2023

@plummercj
The serviceability label was successfully added.

@plummercj
Copy link
Contributor

So JDK-8226420 can be closed as a duplicate
You can't both close the CR as a duplicate and also use it as the CR to remove the problem list references. Perhaps you should use a subtask of JDK-8240711 or JDK-8226420 for this problem list cleanup.

@mlbridge
Copy link

mlbridge bot commented Sep 1, 2023

Webrevs

@alexmenkov
Copy link
Author

/issue JDK-8315563

@openjdk
Copy link

openjdk bot commented Sep 2, 2023

@alexmenkov
Adding additional issue to issue list: 8315563: Remove references to JDK-8226420 from problem list.

@alexmenkov
Copy link
Author

/issue remove JDK-8226420

@openjdk
Copy link

openjdk bot commented Sep 2, 2023

@alexmenkov The issue 8226420 was not found in the list of additional solved issues. The list currently contains these issues: 8315563

@alexmenkov alexmenkov closed this Sep 2, 2023
@alexmenkov alexmenkov deleted the jstatd_port branch September 2, 2023 00:45
@alexmenkov alexmenkov restored the jstatd_port branch September 2, 2023 00:45
@alexmenkov alexmenkov deleted the jstatd_port branch September 2, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review serviceability serviceability-dev@openjdk.org
2 participants