You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logic to detect "port in use" case and retry was implemented in the test by JDK-8240711.
Infra issue with some test host when system software listened on port 1099 was resolved long time ago.
So JDK-8226420 has been closed as a duplicate.
The fix removes references to 8226420 from problemlist (the tests remain problemlisted due other issues).
Progress
Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
Issues
JDK-8226420: sun/tools/jstatd tests failed with Port already in use (Bug - P4) ⚠️ Issue is not open.
JDK-8315563: Remove references to JDK-8226420 from problem list (Sub-task - P4)
👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
@alexmenkov To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.
So JDK-8226420 can be closed as a duplicate
You can't both close the CR as a duplicate and also use it as the CR to remove the problem list references. Perhaps you should use a subtask of JDK-8240711 or JDK-8226420 for this problem list cleanup.
rfrPull request is ready for reviewserviceabilityserviceability-dev@openjdk.org
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logic to detect "port in use" case and retry was implemented in the test by JDK-8240711.
Infra issue with some test host when system software listened on port 1099 was resolved long time ago.
So JDK-8226420 has been closed as a duplicate.
The fix removes references to 8226420 from problemlist (the tests remain problemlisted due other issues).
Progress
Issues
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15546/head:pull/15546$ git checkout pull/15546Update a local copy of the PR:
$ git checkout pull/15546$ git pull https://git.openjdk.org/jdk.git pull/15546/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15546View PR using the GUI difftool:
$ git pr show -t 15546Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15546.diff
Webrev
Link to Webrev Comment