8315566: [JVMCI] deadlock in JVMCI startup when bad option specified

[dougxc]

This PR changes HotSpotJVMCIRuntime.vmEventListeners to be initialized in the HotSpotJVMCIRuntime constructor. This avoids a deadlock that can occur when this list is lazily initialized. Lazily initializing this list has no measurable performance benefit, especially in the context of libgraal.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8315566: [JVMCI] deadlock in JVMCI startup when bad option specified (Bug - P3)

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer)
• Tom Rodriguez (@tkrodriguez - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15549/head:pull/15549
$ git checkout pull/15549

Update a local copy of the PR:
$ git checkout pull/15549
$ git pull https://git.openjdk.org/jdk.git pull/15549/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15549

View PR using the GUI difftool:
$ git pr show -t 15549

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15549.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dougxc The following labels will be automatically applied to this pull request:

• graal
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (64a02a43)

[TobiHartmann]

Looks reasonable to me.

[openjdk]

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315566: [JVMCI] deadlock in JVMCI startup when bad option specified

Reviewed-by: thartmann, never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• ab12c5d: 8315549: CITime misreports code/total nmethod sizes
• ba8d5c2: 8315582: Exclude compiler/codecache/CodeCacheFullCountTest.java with Xcomp
• 75d4ac2: 8311775: [TEST] duplicate verifyHeapDump in several tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dougxc]

Thanks for the reviews.

/integrate

[openjdk]

Going to push as commit d1cabe4.
Since your change was applied there have been 9 commits pushed to the master branch:

• 94a74a0: 8315534: Incorrect warnings about implicit annotation processing
• 84425a6: 8315452: Erroneous AST missing modifiers for partial input
• 3094fd1: 8314662: jshell shows duplicated signatures of javap
• 0d52c82: 8310220: IGV: dump graph after each IGVN step at level 4
• adfc1d6: 8313323: javac -g on a java file which uses unnamed variable leads to ClassFormatError when launching that class
• 2dc930d: 8314997: Missing optimization opportunities due to missing try_clean_mem_phi() calls
• ab12c5d: 8315549: CITime misreports code/total nmethod sizes
• ba8d5c2: 8315582: Exclude compiler/codecache/CodeCacheFullCountTest.java with Xcomp
• 75d4ac2: 8311775: [TEST] duplicate verifyHeapDump in several tests

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc Pushed as commit d1cabe4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.