-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8257574: C2: "failed: parsing found no loops but there are some" assert failure #1556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back roland! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@rwestrel This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 74 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@TobiHartmann @neliasso @chhagedorn thanks for the reviews |
/integrate |
@rwestrel Since your change was applied there have been 80 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 86b6575. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The assert fires because the loop only has an infinite loop which
causes the has_loops flag to be cleared. But because a NeverBranch is
also added to the graph on the next pass of loop opts (for
verification), C2 finds a loop and that's inconsistent with the
has_loops flag. This is supposed to be handled by the
only_has_infinite_loops() call in the assert but not in this case
because the loop is not an innermost loop.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1556/head:pull/1556
$ git checkout pull/1556