Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315648: Add test for JDK-8309979 changes #15561

Closed
wants to merge 1 commit into from
Closed

Conversation

wkia
Copy link

@wkia wkia commented Sep 4, 2023

This change added a simple check in test/hotspot/jtreg/serviceability/sa/ClhsdbDumpclass.java if BootstrapMethods attribute was dumped. (similar to test changes in PR #14556)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315648: Add test for JDK-8309979 changes (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15561/head:pull/15561
$ git checkout pull/15561

Update a local copy of the PR:
$ git checkout pull/15561
$ git pull https://git.openjdk.org/jdk.git pull/15561/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15561

View PR using the GUI difftool:
$ git pr show -t 15561

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15561.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 4, 2023

👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 4, 2023
@openjdk
Copy link

openjdk bot commented Sep 4, 2023

@wkia The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Sep 4, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 4, 2023

Webrevs

@plummercj
Copy link
Contributor

I think the CR could use a better title. Maybe Add test coverage for JDK-8309979 changes

@openjdk
Copy link

openjdk bot commented Sep 5, 2023

@wkia This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315648: Add test for JDK-8309979 changes

Reviewed-by: cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

  • 5cbff24: 8315406: [REDO] serviceability/jdwp/AllModulesCommandTest.java ignores VM flags
  • 7a08e6b: 8313575: Refactor PKCS11Test tests
  • d3ee704: 8315563: Remove references to JDK-8226420 from problem list
  • aba89f2: 8312213: Remove unnecessary TEST instructions on x86 when flags reg will already be set
  • 1f4cdb3: 8315127: CDSMapTest fails with incorrect number of oop references
  • 939d7c5: 8161536: sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java fails with ProviderException
  • ebe3127: 8315717: ProblemList serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC
  • 969fcdb: 8314191: C2 compilation fails with "bad AD file"
  • cef9fff: 8305507: Add support for grace period before AbortVMOnSafepointTimeout triggers
  • ed2b467: 8315499: build using devkit on Linux ppc64le RHEL puts path to devkit into libsplashscreen
  • ... and 14 more: https://git.openjdk.org/jdk/compare/84425a62904f84601affc9710eefece88665374a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@plummercj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 5, 2023
@wkia wkia changed the title 8315648: No tests were modified after JDK-8309979 8315648: Add test for JDK-8309979 changes Sep 6, 2023
@wkia
Copy link
Author

wkia commented Sep 6, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 6, 2023
@openjdk
Copy link

openjdk bot commented Sep 6, 2023

@wkia
Your change (at version 3f93b80) is now ready to be sponsored by a Committer.

@yan-too
Copy link

yan-too commented Sep 6, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 6, 2023

Going to push as commit a258fc4.
Since your change was applied there have been 25 commits pushed to the master branch:

  • 5d3fdc1: 8315612: RISC-V: intrinsic for unsignedMultiplyHigh
  • 5cbff24: 8315406: [REDO] serviceability/jdwp/AllModulesCommandTest.java ignores VM flags
  • 7a08e6b: 8313575: Refactor PKCS11Test tests
  • d3ee704: 8315563: Remove references to JDK-8226420 from problem list
  • aba89f2: 8312213: Remove unnecessary TEST instructions on x86 when flags reg will already be set
  • 1f4cdb3: 8315127: CDSMapTest fails with incorrect number of oop references
  • 939d7c5: 8161536: sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java fails with ProviderException
  • ebe3127: 8315717: ProblemList serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC
  • 969fcdb: 8314191: C2 compilation fails with "bad AD file"
  • cef9fff: 8305507: Add support for grace period before AbortVMOnSafepointTimeout triggers
  • ... and 15 more: https://git.openjdk.org/jdk/compare/84425a62904f84601affc9710eefece88665374a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 6, 2023
@openjdk openjdk bot closed this Sep 6, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 6, 2023
@openjdk
Copy link

openjdk bot commented Sep 6, 2023

@yan-too @wkia Pushed as commit a258fc4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@wkia wkia deleted the test-fix branch October 25, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
3 participants