8314260: Unable to load system libraries on Windows when using a SecurityManager

[minborg]

This PR proposes to read the system environment variable "SystemRoot" using a privileged operation so it will work in the event a default SecurityManager is in place.

As the SecurityManager is deprecated for removal, no support methods were added for reading environmental variables.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8314260: Unable to load system libraries on Windows when using a SecurityManager (Bug - P3)

Reviewers

• Jorn Vernee (@JornVernee - Reviewer)

Contributors

• Jorn Vernee <jvernee@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15564/head:pull/15564
$ git checkout pull/15564

Update a local copy of the PR:
$ git checkout pull/15564
$ git pull https://git.openjdk.org/jdk.git pull/15564/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15564

View PR using the GUI difftool:
$ git pr show -t 15564

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15564.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@minborg The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (16e74316)
• 02: Full - Incremental (0cc7c381)
• 01: Full - Incremental (74c3d2c9)
• 00: Full (6b8e4299)

[minborg]

/contributor add jvernee

[openjdk]

@minborg
Contributor Jorn Vernee <jvernee@openjdk.org> successfully added.

[openjdk]

@minborg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314260: Unable to load system libraries on Windows when using a SecurityManager

Co-authored-by: Jorn Vernee <jvernee@openjdk.org>
Reviewed-by: jvernee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

• 726c9c9: 8315735: VerifyError when switch statement used with synchronized block
• fd6442c: 8315602: Open source swing security manager test
• e22eb06: 8315651: Stop hiding AIX specific multicast socket errors via NetworkConfiguration (aix)
• 9887cd8: 8315751: RandomTestBsi1999 fails often with timeouts on Linux ppc64le
• 8107eab: 8314121: test tools/jpackage/share/RuntimePackageTest.java#id0 fails on RHEL8
• ab28300: 8315698: Crash when comparing BasicType as int after JDK-8310577
• b05198a: 8315600: Open source few more headless Swing misc tests
• 4127fbb: 8315606: Open source few swing text/html tests
• 9402548: 8268719: Force execution (and source) code page used when compiling on Windows
• 86a18f5: 8314604: j.text.DecimalFormat behavior regarding patterns is not clear
• ... and 26 more: https://git.openjdk.org/jdk/compare/fe4f90021ffd44cb0af34f39d4ca0a7e44605c92...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[minborg]

/integrate

[openjdk]

Going to push as commit b408a82.
Since your change was applied there have been 36 commits pushed to the master branch:

• 726c9c9: 8315735: VerifyError when switch statement used with synchronized block
• fd6442c: 8315602: Open source swing security manager test
• e22eb06: 8315651: Stop hiding AIX specific multicast socket errors via NetworkConfiguration (aix)
• 9887cd8: 8315751: RandomTestBsi1999 fails often with timeouts on Linux ppc64le
• 8107eab: 8314121: test tools/jpackage/share/RuntimePackageTest.java#id0 fails on RHEL8
• ab28300: 8315698: Crash when comparing BasicType as int after JDK-8310577
• b05198a: 8315600: Open source few more headless Swing misc tests
• 4127fbb: 8315606: Open source few swing text/html tests
• 9402548: 8268719: Force execution (and source) code page used when compiling on Windows
• 86a18f5: 8314604: j.text.DecimalFormat behavior regarding patterns is not clear
• ... and 26 more: https://git.openjdk.org/jdk/compare/fe4f90021ffd44cb0af34f39d4ca0a7e44605c92...master

Your commit was automatically rebased without conflicts.

[openjdk]

@minborg Pushed as commit b408a82.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.