8268719: Force execution (and source) code page used when compiling on Windows

[swesonga]

Set MSVC source and execution character sets to UTF-8 to enable Visual C++ to compile all source files regardless of the active code page on Windows. This avoids build errors due to "warning C4819: The file contains a character that cannot be represented in the current code page (932). Save the file in Unicode format to prevent data loss"

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8268719: Force execution (and source) code page used when compiling on Windows (Enhancement - P4)

Reviewers

• Julian Waters (@TheShermanTanker - Committer)
• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15569/head:pull/15569
$ git checkout pull/15569

Update a local copy of the PR:
$ git checkout pull/15569
$ git pull https://git.openjdk.org/jdk.git pull/15569/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15569

View PR using the GUI difftool:
$ git pr show -t 15569

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15569.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back swesonga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@swesonga The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4281696c)

[erikj79]

I think this makes sense.

[openjdk]

@swesonga This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268719: Force execution (and source) code page used when compiling on Windows

Reviewed-by: jwaters, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• 024133b: 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags)
• 62a953f: 8315689: G1: Remove unused init_hash_seed
• cfc1489: 8315579: SPARC64 builds are broken after JDK-8304913
• f6c203e: 8314949: linux PPC64 Big Endian: Implementation of Foreign Function & Memory API
• a01b3fb: 8288660: JavaDoc should be more helpful if it doesn't recognize a tag
• ba1a463: 8315377: C2: assert(u->find_out_with(Op_AddP) == nullptr) failed: more than 2 chained AddP nodes?
• a258fc4: 8315648: Add test for JDK-8309979 changes
• 5d3fdc1: 8315612: RISC-V: intrinsic for unsignedMultiplyHigh
• 5cbff24: 8315406: [REDO] serviceability/jdwp/AllModulesCommandTest.java ignores VM flags
• 7a08e6b: 8313575: Refactor PKCS11Test tests
• ... and 7 more: https://git.openjdk.org/jdk/compare/ed2b4673de6893047407c61f82b5e68741459876...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheShermanTanker, @erikj79) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[swesonga]

/integrate

[openjdk]

@swesonga
Your change (at version 4281696) is now ready to be sponsored by a Committer.

[TheShermanTanker]

/sponsor

[openjdk]

Going to push as commit 9402548.
Since your change was applied there have been 20 commits pushed to the master branch:

• 86a18f5: 8314604: j.text.DecimalFormat behavior regarding patterns is not clear
• bd47781: 8315554: C1: Replace "cmp reg, 0" with "test reg, reg" on x86
• 25e85db: 8307468: CDS Lambda Proxy classes are regenerated in dynamic dump
• 024133b: 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags)
• 62a953f: 8315689: G1: Remove unused init_hash_seed
• cfc1489: 8315579: SPARC64 builds are broken after JDK-8304913
• f6c203e: 8314949: linux PPC64 Big Endian: Implementation of Foreign Function & Memory API
• a01b3fb: 8288660: JavaDoc should be more helpful if it doesn't recognize a tag
• ba1a463: 8315377: C2: assert(u->find_out_with(Op_AddP) == nullptr) failed: more than 2 chained AddP nodes?
• a258fc4: 8315648: Add test for JDK-8309979 changes
• ... and 10 more: https://git.openjdk.org/jdk/compare/ed2b4673de6893047407c61f82b5e68741459876...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheShermanTanker @swesonga Pushed as commit 9402548.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.