Skip to content

8315717: ProblemList serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC #15570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Sep 5, 2023

A trivial fix to ProblemList serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315717: ProblemList serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15570/head:pull/15570
$ git checkout pull/15570

Update a local copy of the PR:
$ git checkout pull/15570
$ git pull https://git.openjdk.org/jdk.git pull/15570/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15570

View PR using the GUI difftool:
$ git pr show -t 15570

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15570.diff

Webrev

Link to Webrev Comment

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add serviceability
/label add hotspot-gc

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review September 5, 2023 17:17
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 5, 2023

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review hotspot-runtime hotspot-runtime-dev@openjdk.org labels Sep 5, 2023
@openjdk
Copy link

openjdk bot commented Sep 5, 2023

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Sep 5, 2023
@openjdk
Copy link

openjdk bot commented Sep 5, 2023

@dcubed-ojdk
The serviceability label was successfully added.

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@openjdk
Copy link

openjdk bot commented Sep 5, 2023

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315717: ProblemList serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC

Reviewed-by: thartmann, azvegint, kevinw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@dcubed-ojdk
Copy link
Member Author

@TobiHartmann - Thanks for the lightning fast review!

/integrate

@openjdk openjdk bot added ready Pull request is ready to be integrated hotspot-gc hotspot-gc-dev@openjdk.org labels Sep 5, 2023
@openjdk
Copy link

openjdk bot commented Sep 5, 2023

@dcubed-ojdk
The hotspot-gc label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Sep 5, 2023

Webrevs

@kevinjwalls
Copy link
Contributor

Thanks Dan!

@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented Sep 5, 2023

@azvegint and @kevinjwalls - Thanks for the reviews!
I did a fast "/integrate" so your reviews weren't captured by the bot.
Sorry about that.

Update: Still hasn't integrated yet, but maybe there's a chance all the reviews will stick...

@dcubed-ojdk
Copy link
Member Author

This is weird... The "/integrate" didn't work...

@dcubed-ojdk
Copy link
Member Author

/integrate

@dcubed-ojdk
Copy link
Member Author

It still hasn't integrated... The bot must be unhappy today... One more time:

/integrate

@openjdk
Copy link

openjdk bot commented Sep 5, 2023

Going to push as commit ebe3127.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 5, 2023
@openjdk openjdk bot closed this Sep 5, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 5, 2023
@openjdk
Copy link

openjdk bot commented Sep 5, 2023

@dcubed-ojdk Pushed as commit ebe3127.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Sep 5, 2023

@dcubed-ojdk The command integrate can only be used in open pull requests.

@openjdk
Copy link

openjdk bot commented Sep 5, 2023

@dcubed-ojdk The command integrate can only be used in open pull requests.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8315717 branch September 5, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

4 participants