-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8315717: ProblemList serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC #15570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/label add hotspot-runtime |
👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into |
@dcubed-ojdk |
@dcubed-ojdk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and trivial.
@dcubed-ojdk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
@TobiHartmann - Thanks for the lightning fast review! /integrate |
@dcubed-ojdk |
Thanks Dan! |
@azvegint and @kevinjwalls - Thanks for the reviews! Update: Still hasn't integrated yet, but maybe there's a chance all the reviews will stick... |
This is weird... The "/integrate" didn't work... |
/integrate |
It still hasn't integrated... The bot must be unhappy today... One more time: /integrate |
Going to push as commit ebe3127. |
@dcubed-ojdk Pushed as commit ebe3127. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
@dcubed-ojdk The command |
@dcubed-ojdk The command |
A trivial fix to ProblemList serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15570/head:pull/15570
$ git checkout pull/15570
Update a local copy of the PR:
$ git checkout pull/15570
$ git pull https://git.openjdk.org/jdk.git pull/15570/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15570
View PR using the GUI difftool:
$ git pr show -t 15570
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15570.diff
Webrev
Link to Webrev Comment