8314831: NMT tests ignore vm flags

[mseledts]

Some NMT tests do not pass Java/JVM test command line options (flags) to the child process. Such tests should be examined and broken down into 2 categories:

• a test intentionally does not pass flags to child process - mark such tests with "@requires vm.flagless"
• tests did not pass flags to child process by mistake - fix them to use the right ProcessTools method that passes test flags to child process

For details see the JBS issue, including on how the tests were assigned to each category and the reasoning behind it.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8314831: NMT tests ignore vm flags (Sub-task - P3)

Reviewers

• Leonid Mesnik (@lmesnik - Reviewer)
• Thomas Stuefe (@tstuefe - Reviewer)
• Gerard Ziemski (@gerard-ziemski - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15576/head:pull/15576
$ git checkout pull/15576

Update a local copy of the PR:
$ git checkout pull/15576
$ git pull https://git.openjdk.org/jdk.git pull/15576/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15576

View PR using the GUI difftool:
$ git pr show -t 15576

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15576.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mseledtsov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mseledts The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mseledts]

Testing:

• ran NMT tests (test/hotspot/jtreg/runtime/NMT) w/o flags - PASS
• ran NMT tests with various flags - see JBS issue for details

[lmesnik]

Changes looks good.

[openjdk]

@mseledts This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314831: NMT tests ignore vm flags

Reviewed-by: lmesnik, stuefe, gziemski

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• 86a18f5: 8314604: j.text.DecimalFormat behavior regarding patterns is not clear
• bd47781: 8315554: C1: Replace "cmp reg, 0" with "test reg, reg" on x86
• 25e85db: 8307468: CDS Lambda Proxy classes are regenerated in dynamic dump
• 024133b: 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags)
• 62a953f: 8315689: G1: Remove unused init_hash_seed
• cfc1489: 8315579: SPARC64 builds are broken after JDK-8304913
• f6c203e: 8314949: linux PPC64 Big Endian: Implementation of Foreign Function & Memory API
• a01b3fb: 8288660: JavaDoc should be more helpful if it doesn't recognize a tag
• ba1a463: 8315377: C2: assert(u->find_out_with(Op_AddP) == nullptr) failed: more than 2 chained AddP nodes?
• a258fc4: 8315648: Add test for JDK-8309979 changes
• ... and 5 more: https://git.openjdk.org/jdk/compare/1f4cdb327f46085d3134d1d1164fccac35904566...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (c674a141)

[tstuefe]

Okay. Are createTestJVM and createJavaProcessBuilder equivalent?

[gerard-ziemski]

The ProcessTools.createJavaProcessBuilder() -> ProcessTools.createTestJvm() change looks OK, but shouldn't we use createJavaProcessBuilderIgnoreTestJavaOpts() for those tests that do not want arguments passed, instead of tagging them with "@requires vm.flagless" or am I understanding the point of #15452 incorrectly?

[mseledts]

To answer a question from Thomas: Are createTestJVM and createJavaProcessBuilder equivalent?

The difference is that createTestJVM() will pass the main/parent JVM command line flags to the child JVM, while createJavaProcessBuilder() will not.

[mseledts]

To answer a question from Gerard: shouldn't we use createJavaProcessBuilderIgnoreTestJavaOpts() ?
A: even though MR for " 8315097: Rename createJavaProcessBuilder #15452 " is related in topic to this change, it is still under discussion and could take some time to make final decision on it. Once decision is done and change 15452 is approved, the global renaming will be applied.

As far as tagging tests with "@requires vm.flagless" - this is our (HotSpot) recommended way of tagging tests that do not pass the JVM args to child VM. This is done in addition to using createJavaProcessBuilder(). This provides us a uniform way of knowing which tests do not pass flags to child VMs, we can make proper test selection when executing with flags based on that information.

[RogerRiggs]

Specifically, createTestJVM() prepends flags from the system properties test.vm.opts and test.java.opts usually set by jtreg.

[gerard-ziemski]

To answer a question from Gerard: shouldn't we use createJavaProcessBuilderIgnoreTestJavaOpts() ? A: even though MR for " 8315097: Rename createJavaProcessBuilder #15452 " is related in topic to this change, it is still under discussion and could take some time to make final decision on it. Once decision is done and change 15452 is approved, the global renaming will be applied.

As far as tagging tests with "@requires vm.flagless" - this is our (HotSpot) recommended way of tagging tests that do not pass the JVM args to child VM. This is done in addition to using createJavaProcessBuilder(). This provides us a uniform way of knowing which tests do not pass flags to child VMs, we can make proper test selection when executing with flags based on that information.

I thought we may want to use 15452, but if we have to get this patch in now, then tweak it later a bit and you're OK with that, then so am I.

[mseledts]

Thank you Leonid, Thomas, Gerard.

/integrate

[openjdk]

Going to push as commit 9bf3dee.
Since your change was applied there have been 31 commits pushed to the master branch:

• b74805d: 8315863: [GHA] Update checkout action to use v4
• 1cae0f5: 8315220: Event NativeLibraryLoad breaks invariant by taking a stacktrace when thread is in state _thread_in_native
• 8f7e29b: 8313422: test/langtools/tools/javac 144 test classes uses com.sun.tools.classfile library
• 8557205: 8312569: RISC-V: Missing intrinsics for Math.ceil, floor, rint
• 2fd870a: 8315444: Convert test/jdk/tools to Classfile API
• 81f8c57: 8314632: Intra-case dominance check fails in the presence of a guard
• b408a82: 8314260: Unable to load system libraries on Windows when using a SecurityManager
• 726c9c9: 8315735: VerifyError when switch statement used with synchronized block
• fd6442c: 8315602: Open source swing security manager test
• e22eb06: 8315651: Stop hiding AIX specific multicast socket errors via NetworkConfiguration (aix)
• ... and 21 more: https://git.openjdk.org/jdk/compare/1f4cdb327f46085d3134d1d1164fccac35904566...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mseledts Pushed as commit 9bf3dee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.