8315743: RISC-V: Cleanup masm lr()/sc() methods

[robehn]

Hi, please consider this small cleanup.

Tested tier1 on qemu RV

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8315743: RISC-V: Cleanup masm lr()/sc() methods (Enhancement - P5)

Reviewers

• Fei Yang (@RealFYang - Reviewer)
• Ludovic Henry (@luhenry - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15578/head:pull/15578
$ git checkout pull/15578

Update a local copy of the PR:
$ git checkout pull/15578
$ git pull https://git.openjdk.org/jdk.git pull/15578/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15578

View PR using the GUI difftool:
$ git pr show -t 15578

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15578.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rehn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@robehn The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (17d32801)

[RealFYang]

That looks more reasonable. Thanks for the cleanup.

[openjdk]

@robehn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315743: RISC-V: Cleanup masm lr()/sc() methods

Reviewed-by: fyang, luhenry

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 77 new commits pushed to the master branch:

• 6f2684b: 8315948: JDK-8315818 broke Xcomp on libgraal
• 8b4f9a8: 8315990: Amend problemlisted tests to proper position
• 455c471: 8313277: Resolve multiple definition of 'normalize' when statically linking JDK native libraries with user code
• 3b422d0: 8316094: Problemlist compiler/rangechecks/TestRangeCheckHoistingScaledIV.java
• f55e799: 8316038: Fix doc typos in java.io.Console and java.util.Scanner
• 9480078: 8315550: G1: Fix -Wconversion warnings in g1NUMA
• d08258f: 8315938: Deprecate for removal Unsafe methods that have standard APIs for many releases
• fda142f: 8312174: missing JVMTI events from vthreads parked during JVMTI attach
• d0be73a: 8041488: Locale-Dependent List Patterns
• dd214d0: 8315437: Enable parallelism in vmTestbase/nsk/monitoring/stress/classload tests
• ... and 67 more: https://git.openjdk.org/jdk/compare/5cbff2460812fee707f9d96ab00a628d1ce3fbef...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[robehn]

That looks more reasonable. Thanks for the cleanup.

Thanks!

[robehn]

/integrate

[openjdk]

Going to push as commit 1ebf510.
Since your change was applied there have been 89 commits pushed to the master branch:

• bd52bbf: 8316060: test/hotspot/jtreg/runtime/reflect/ReflectOutOfMemoryError.java may fail if heap is huge
• dde1155: 8315946: DecimalFormat and CompactNumberFormat do allow U+FFFE and U+FFFF in the pattern
• a9679ac: 8253620: Debug symbols for tests missing on macos and windows
• 020255a: 8267174: Many test files have the wrong Copyright header
• ac2dfe4: 8313865: Always true condition in sun.nio.cs.CharsetMapping#readINDEXC2B
• 947dee7: 8316113: Infinite permission checking loop in java/net/spi/InetAddressResolverProvider/RuntimePermissionTest
• 1d702d2: 8313800: AArch64: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved
• e084516: 8315968: Move java.util.Digits to jdk.internal.util and refactor to reduce duplication
• d75d977: 8285447: StackWalker minimal batch size should be optimized for getCallerClass
• fc3e826: 8314832: Few runtime/os tests ignore vm flags
• ... and 79 more: https://git.openjdk.org/jdk/compare/5cbff2460812fee707f9d96ab00a628d1ce3fbef...master

Your commit was automatically rebased without conflicts.

[openjdk]

@robehn Pushed as commit 1ebf510.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.