Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315600: Open source few more headless Swing misc tests #15582

Closed
wants to merge 5 commits into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Sep 6, 2023

Few more closed swing headless tests are opensourced


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315600: Open source few more headless Swing misc tests (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15582/head:pull/15582
$ git checkout pull/15582

Update a local copy of the PR:
$ git checkout pull/15582
$ git pull https://git.openjdk.org/jdk.git pull/15582/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15582

View PR using the GUI difftool:
$ git pr show -t 15582

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15582.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 6, 2023

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 6, 2023
@openjdk
Copy link

openjdk bot commented Sep 6, 2023

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 6, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 6, 2023

Webrevs

if (r.width != r2.width) {
throw new RuntimeException("Test failed");
}
} catch(Exception e) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
} catch(Exception e) {
} catch (Exception e) {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is gone in the latest version.

@openjdk
Copy link

openjdk bot commented Sep 6, 2023

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315600: Open source few more headless Swing misc tests

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 67 new commits pushed to the master branch:

  • bd47781: 8315554: C1: Replace "cmp reg, 0" with "test reg, reg" on x86
  • 25e85db: 8307468: CDS Lambda Proxy classes are regenerated in dynamic dump
  • 024133b: 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags)
  • 62a953f: 8315689: G1: Remove unused init_hash_seed
  • cfc1489: 8315579: SPARC64 builds are broken after JDK-8304913
  • f6c203e: 8314949: linux PPC64 Big Endian: Implementation of Foreign Function & Memory API
  • a01b3fb: 8288660: JavaDoc should be more helpful if it doesn't recognize a tag
  • ba1a463: 8315377: C2: assert(u->find_out_with(Op_AddP) == nullptr) failed: more than 2 chained AddP nodes?
  • a258fc4: 8315648: Add test for JDK-8309979 changes
  • 5d3fdc1: 8315612: RISC-V: intrinsic for unsignedMultiplyHigh
  • ... and 57 more: https://git.openjdk.org/jdk/compare/145d8bc1a3ef4f4fe0c10385be111838e7ed9250...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 6, 2023
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps, this file, bug4992178.java, can be moved into UndoManager folder where bug4706533.java is put. These two tests are closely related, they test the functionality of UndoManager.setLimit.

@prsadhuk
Copy link
Contributor Author

prsadhuk commented Sep 7, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Sep 7, 2023

Going to push as commit b05198a.
Since your change was applied there have been 70 commits pushed to the master branch:

  • 4127fbb: 8315606: Open source few swing text/html tests
  • 9402548: 8268719: Force execution (and source) code page used when compiling on Windows
  • 86a18f5: 8314604: j.text.DecimalFormat behavior regarding patterns is not clear
  • bd47781: 8315554: C1: Replace "cmp reg, 0" with "test reg, reg" on x86
  • 25e85db: 8307468: CDS Lambda Proxy classes are regenerated in dynamic dump
  • 024133b: 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags)
  • 62a953f: 8315689: G1: Remove unused init_hash_seed
  • cfc1489: 8315579: SPARC64 builds are broken after JDK-8304913
  • f6c203e: 8314949: linux PPC64 Big Endian: Implementation of Foreign Function & Memory API
  • a01b3fb: 8288660: JavaDoc should be more helpful if it doesn't recognize a tag
  • ... and 60 more: https://git.openjdk.org/jdk/compare/145d8bc1a3ef4f4fe0c10385be111838e7ed9250...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 7, 2023
@openjdk openjdk bot closed this Sep 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 7, 2023
@openjdk
Copy link

openjdk bot commented Sep 7, 2023

@prsadhuk Pushed as commit b05198a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the 8315600 branch September 7, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants