Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315651: Stop hiding AIX specific multicast socket errors via NetworkConfiguration (aix) #15586

Closed
wants to merge 3 commits into from

Conversation

TOatGithub
Copy link
Contributor

@TOatGithub TOatGithub commented Sep 6, 2023


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315651: Stop hiding AIX specific multicast socket errors via NetworkConfiguration (aix) (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15586/head:pull/15586
$ git checkout pull/15586

Update a local copy of the PR:
$ git checkout pull/15586
$ git pull https://git.openjdk.org/jdk.git pull/15586/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15586

View PR using the GUI difftool:
$ git pr show -t 15586

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15586.diff

Webrev

Link to Webrev Comment

@TOatGithub
Copy link
Contributor Author

Description:
test/lib/jdk/test/lib/NetworkConfiguration.java has special code to avoid running into the error to be resolved by the main task JDK-8308807.
In order to have a clear picture and to potentially see other hidden bugs this extra code should be removed.
One example is java/net/MulticastSocket/Promiscuous.java, which currently fails because from NetworkConfiguration no ip4MulticastInterface is provided at all. If the AIX specific filter is removed we see the problem addressed in main task.

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 6, 2023

👋 Welcome back TOatGithub! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@TOatGithub
Copy link
Contributor Author

/label net

@openjdk openjdk bot added the net net-dev@openjdk.org label Sep 6, 2023
@openjdk
Copy link

openjdk bot commented Sep 6, 2023

@TOatGithub
The net label was successfully added.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 6, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 6, 2023

Webrevs

// to be fixed with JDK-8308807 -> comment this aviation
//if (Platform.isAix() && isIPv6Available() && !hasIp6Addresses(nif)) {
// return false;
//}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this entire comment block be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did so with latest commit

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this removal looks okay to me although it's impossible to know if tests will now fail in some AIX configs.

@openjdk
Copy link

openjdk bot commented Sep 6, 2023

@TOatGithub This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315651: Stop hiding AIX specific multicast socket errors via NetworkConfiguration (aix)

Reviewed-by: alanb, mdoerr, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

  • 9887cd8: 8315751: RandomTestBsi1999 fails often with timeouts on Linux ppc64le
  • 8107eab: 8314121: test tools/jpackage/share/RuntimePackageTest.java#id0 fails on RHEL8
  • ab28300: 8315698: Crash when comparing BasicType as int after JDK-8310577
  • b05198a: 8315600: Open source few more headless Swing misc tests
  • 4127fbb: 8315606: Open source few swing text/html tests
  • 9402548: 8268719: Force execution (and source) code page used when compiling on Windows
  • 86a18f5: 8314604: j.text.DecimalFormat behavior regarding patterns is not clear
  • bd47781: 8315554: C1: Replace "cmp reg, 0" with "test reg, reg" on x86
  • 25e85db: 8307468: CDS Lambda Proxy classes are regenerated in dynamic dump
  • 024133b: 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags)
  • ... and 27 more: https://git.openjdk.org/jdk/compare/6c821f5e1ddfae26c445f0cd5fe9205f49bfddee...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman, @TheRealMDoerr, @RealCLanger) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 6, 2023
@TOatGithub
Copy link
Contributor Author

Thanks, Alan for reviewing!
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 6, 2023
@openjdk
Copy link

openjdk bot commented Sep 6, 2023

@TOatGithub
Your change (at version 4f24749) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 7, 2023

Going to push as commit e22eb06.
Since your change was applied there have been 37 commits pushed to the master branch:

  • 9887cd8: 8315751: RandomTestBsi1999 fails often with timeouts on Linux ppc64le
  • 8107eab: 8314121: test tools/jpackage/share/RuntimePackageTest.java#id0 fails on RHEL8
  • ab28300: 8315698: Crash when comparing BasicType as int after JDK-8310577
  • b05198a: 8315600: Open source few more headless Swing misc tests
  • 4127fbb: 8315606: Open source few swing text/html tests
  • 9402548: 8268719: Force execution (and source) code page used when compiling on Windows
  • 86a18f5: 8314604: j.text.DecimalFormat behavior regarding patterns is not clear
  • bd47781: 8315554: C1: Replace "cmp reg, 0" with "test reg, reg" on x86
  • 25e85db: 8307468: CDS Lambda Proxy classes are regenerated in dynamic dump
  • 024133b: 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags)
  • ... and 27 more: https://git.openjdk.org/jdk/compare/6c821f5e1ddfae26c445f0cd5fe9205f49bfddee...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 7, 2023
@openjdk openjdk bot closed this Sep 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 7, 2023
@openjdk
Copy link

openjdk bot commented Sep 7, 2023

@TheRealMDoerr @TOatGithub Pushed as commit e22eb06.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
4 participants