Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315765: G1: Incorrect use of G1LastPLABAverageOccupancy #15587

Closed
wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Sep 6, 2023

Simple fix in calculating the number of plab refills. The default value is 50, so no real effect.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315765: G1: Incorrect use of G1LastPLABAverageOccupancy (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15587/head:pull/15587
$ git checkout pull/15587

Update a local copy of the PR:
$ git checkout pull/15587
$ git pull https://git.openjdk.org/jdk.git pull/15587/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15587

View PR using the GUI difftool:
$ git pr show -t 15587

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15587.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 6, 2023

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8315765 8315765: G1: Incorrect use of G1LastPLABAverageOccupancy Sep 6, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 6, 2023
@openjdk
Copy link

openjdk bot commented Sep 6, 2023

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Sep 6, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 6, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 11, 2023

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315765: G1: Incorrect use of G1LastPLABAverageOccupancy

Reviewed-by: iwalulya, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 57 new commits pushed to the master branch:

  • 4cb4637: 8315970: Big-endian issues after JDK-8310929
  • ae08143: 8315611: Open source swing text/html and tree test
  • 7b3e697: 8315855: G1: Revise signature of set_humongous_candidate
  • 1941290: 8315942: Sort platform enums and definitions after JDK-8304913 follow-ups
  • 996b336: 8315781: Reduce the max value of GCDrainStackTargetSize
  • 35bccac: 8315841: RISC-V: Check for hardware TSO support
  • a04c6c1: 8315609: Open source few more swing text/html tests
  • dab1c21: 8314491: Linux: jexec launched via PATH fails to find java
  • 9a83d55: 8315373: Change VirtualThread to unmount after freezing, re-mount before thawing
  • 68f6941: 8314452: Explicitly indicate inlining success/failure in PrintInlining
  • ... and 47 more: https://git.openjdk.org/jdk/compare/62a953f40224589bb72864427181f69da526d391...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 11, 2023
@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Sep 11, 2023

Going to push as commit d06a564.
Since your change was applied there have been 58 commits pushed to the master branch:

  • 66b6a5a: 8277954: Replace use of monitors with explicit locks in the JDK LDAP provider implementation
  • 4cb4637: 8315970: Big-endian issues after JDK-8310929
  • ae08143: 8315611: Open source swing text/html and tree test
  • 7b3e697: 8315855: G1: Revise signature of set_humongous_candidate
  • 1941290: 8315942: Sort platform enums and definitions after JDK-8304913 follow-ups
  • 996b336: 8315781: Reduce the max value of GCDrainStackTargetSize
  • 35bccac: 8315841: RISC-V: Check for hardware TSO support
  • a04c6c1: 8315609: Open source few more swing text/html tests
  • dab1c21: 8314491: Linux: jexec launched via PATH fails to find java
  • 9a83d55: 8315373: Change VirtualThread to unmount after freezing, re-mount before thawing
  • ... and 48 more: https://git.openjdk.org/jdk/compare/62a953f40224589bb72864427181f69da526d391...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 11, 2023
@openjdk openjdk bot closed this Sep 11, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 11, 2023
@openjdk
Copy link

openjdk bot commented Sep 11, 2023

@albertnetymk Pushed as commit d06a564.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the g1-plab-occupancy branch September 11, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants