-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8257533: legacy-jre-image includes jpackage and jlink tools #1559
Conversation
👋 Welcome back ihse! A progress list of the required criteria for merging this PR into |
@magicus This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@magicus Since your change was applied there have been 3 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit bff68f1. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
JEP 343 added jdk.jpackage to Module.gmk/JRE_TOOL_MODULES with the result that the legacy-jre-image builds a run-time image that contains the package and jlink tools. This seems to be an oversight as these tools should not be in the equivalent of what we knew in the past as the "JRE".
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1559/head:pull/1559
$ git checkout pull/1559