JDK-8315486: vmTestbase/nsk/jdwp/ThreadReference/ForceEarlyReturn/forceEarlyReturn002/forceEarlyReturn002.java timed out

[alexmenkov]

To test ForceEarlyReturn command for NO_MORE_FRAMES case the test creates ThreadStartEventRequest with SUSPEND_ALL policy and requests debuggee to start new thread.
If debuggee JVM starts some internal threads before the request is cleared (i.e. we have several ThreadStart events), 2nd event suspends debuggee again and the test fails with timeout.
The change adds THREAD_ONLY modifier to the ThreadStartEventRequest to generate event only for desired thread.
It requires thread ID, so debuggee was updated to create Thread object in advance, debugger reads the thread ID from static field (it does not need to be static, but Debugee class has convenient methods to retrieve class ID and static field value).

Testing: 100 runs of the test on windows-x64-debug,linux-x64-debug,macosx-x64-debug with JTREG_TEST_THREAD_FACTORY=Virtual, with and without "-XX:+UseZGC -XX:+ZGenerational"

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8315486: vmTestbase/nsk/jdwp/ThreadReference/ForceEarlyReturn/forceEarlyReturn002/forceEarlyReturn002.java timed out (Bug - P4)

Reviewers

• Chris Plummer (@plummercj - Reviewer) ⚠️ Review applies to 310115de
• Leonid Mesnik (@lmesnik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15601/head:pull/15601
$ git checkout pull/15601

Update a local copy of the PR:
$ git checkout pull/15601
$ git pull https://git.openjdk.org/jdk.git pull/15601/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15601

View PR using the GUI difftool:
$ git pr show -t 15601

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15601.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexmenkov The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (5736e1c6)
• 00: Full (310115de)

[plummercj]

Overall looks good. Just one minor comment suggestion.

[plummercj]

Maybe add a bit more of a comment here that explains we only want the THREAD_START event for the specified test thread and not any others that might start up.

[openjdk]

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315486: vmTestbase/nsk/jdwp/ThreadReference/ForceEarlyReturn/forceEarlyReturn002/forceEarlyReturn002.java timed out

Reviewed-by: cjplummer, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 246 new commits pushed to the master branch:

• e0f8d16: 8314829: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java ignores vm flags
• 7b1e2bf: 8315415: OutputAnalyzer.shouldMatchByLine() fails in some cases
• da57d2a: 8308592: Framework for CA interoperability testing
• a6d120d: 8316513: Serial: Remove unused invalidate_remembered_set
• 607bd4e: 8316294: AIX: Build fopen system call fails on file _BUILD_LIBJDWP_objectfilenames.txt
• f25c920: 8314774: Optimize URLEncoder
• 7c5f2a2: 8315669: Open source several Swing PopupMenu related tests
• cf74b8c: 8316337: (bf) Concurrency issue in DirectByteBuffer.Deallocator
• 4461eeb: 8312498: Thread::getState and JVM TI GetThreadState should return TIMED_WAITING virtual thread is timed parked
• 670b456: 8315038: Capstone disassembler stops when it sees a bad instruction
• ... and 236 more: https://git.openjdk.org/jdk/compare/b38bcae1bad399d0a3ffc091835bf89140550bc2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[alexmenkov]

Ping. need 1 more review.

[alexmenkov]

/integrate

[openjdk]

Going to push as commit 041510d.
Since your change was applied there have been 300 commits pushed to the master branch:

• ef49e6c: 8316629: j.text.DateFormatSymbols setZoneStrings() exception is unhelpful
• 496264c: 8316435: sun.util.calendar.CalendarSystem subclassing should be restricted
• 1100dbc: 8316695: ProblemList serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java
• d3e8218: 8316306: Open source and convert manual Swing test
• 4e57177: 8316383: NullPointerException in AbstractSAXParser after JDK-8306632
• 3b397c8: 8315965: Open source various AWT applet tests
• c698b45: 8313229: DHEKeySizing.java should be modified to use TLS versions TLSv1, TLSv1.1, TLSv1.2
• 015f6f5: 8315771: [JVMCI] Resolution of bootstrap methods with int[] static arguments
• 83b01cf: 8311922: [macOS] right-Option key fails to generate release event
• 542b300: 8315954: getArgumentValues002.java fails on Graal
• ... and 290 more: https://git.openjdk.org/jdk/compare/b38bcae1bad399d0a3ffc091835bf89140550bc2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexmenkov Pushed as commit 041510d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.