Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315605: G1: Add number of nmethods in code roots scanning statistics #15610

Closed

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Sep 7, 2023

Hi all,

please review this change that adds nmethod count statistics during Code Root Scan to be able to implement JDK-8030815.

Testing: gha, checking that the message appears manually

Thanks,
Thomas


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315605: G1: Add number of nmethods in code roots scanning statistics (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15610/head:pull/15610
$ git checkout pull/15610

Update a local copy of the PR:
$ git checkout pull/15610
$ git pull https://git.openjdk.org/jdk.git pull/15610/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15610

View PR using the GUI difftool:
$ git pr show -t 15610

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15610.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 7, 2023

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8315605 8315605: G1: Add number of nmethods in code roots scanning statistics Sep 7, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 7, 2023
@openjdk
Copy link

openjdk bot commented Sep 7, 2023

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Sep 7, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 7, 2023

Webrevs

@tschatzl tschatzl marked this pull request as draft September 7, 2023 08:58
@tschatzl tschatzl marked this pull request as ready for review September 7, 2023 08:59
@openjdk
Copy link

openjdk bot commented Sep 7, 2023

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315605: G1: Add number of nmethods in code roots scanning statistics

Reviewed-by: iwalulya, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

  • b74805d: 8315863: [GHA] Update checkout action to use v4
  • 1cae0f5: 8315220: Event NativeLibraryLoad breaks invariant by taking a stacktrace when thread is in state _thread_in_native
  • 8f7e29b: 8313422: test/langtools/tools/javac 144 test classes uses com.sun.tools.classfile library
  • 8557205: 8312569: RISC-V: Missing intrinsics for Math.ceil, floor, rint
  • 2fd870a: 8315444: Convert test/jdk/tools to Classfile API
  • 81f8c57: 8314632: Intra-case dominance check fails in the presence of a guard
  • b408a82: 8314260: Unable to load system libraries on Windows when using a SecurityManager
  • 726c9c9: 8315735: VerifyError when switch statement used with synchronized block
  • fd6442c: 8315602: Open source swing security manager test
  • e22eb06: 8315651: Stop hiding AIX specific multicast socket errors via NetworkConfiguration (aix)
  • ... and 28 more: https://git.openjdk.org/jdk/compare/8647f001bbb804503e8491d10f77aa0f34d66bf2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 7, 2023
@tschatzl
Copy link
Contributor Author

tschatzl commented Sep 8, 2023

Thanks @albertnetymk @walulyai for your reviews
/integrate

@openjdk
Copy link

openjdk bot commented Sep 8, 2023

Going to push as commit 7ef059a.
Since your change was applied there have been 51 commits pushed to the master branch:

  • 825e0ed: 8315774: Enable parallelism in vmTestbase/gc/g1/unloading tests
  • dac1727: 8308869: C2: use profile data in subtype checks when profile has more than one class
  • 3c258ac: 8315702: jcmd Thread.dump_to_file slow with millions of virtual threads
  • 3a00ec8: 8312075: FileChooser.win32.newFolder is not updated when changing Locale
  • 806ef08: 8315594: Open source few headless Swing misc tests
  • 4b43c25: 8310929: Optimization for Integer.toString
  • 111ecdb: 8268829: Provide an optimized way to walk the stack with Class object only
  • 716201c: 8314935: Shenandoah: Unable to throw OOME on back-to-back Full GCs
  • 4c6d7fc: 8315795: runtime/Safepoint/TestAbortVMOnSafepointTimeout.java fails after JDK-8305507
  • 7e7ab6e: 8315877: ProblemList vmTestbase/nsk/jvmti/InterruptThread/intrpthrd003/TestDescription.java on macosx-aarch64
  • ... and 41 more: https://git.openjdk.org/jdk/compare/8647f001bbb804503e8491d10f77aa0f34d66bf2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 8, 2023
@openjdk openjdk bot closed this Sep 8, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 8, 2023
@openjdk
Copy link

openjdk bot commented Sep 8, 2023

@tschatzl Pushed as commit 7ef059a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the 8315605-add-nmethod-count-during-scan branch September 8, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants