Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315761: Open source few swing JList and JMenuBar tests #15621

Closed
wants to merge 2 commits into from

Conversation

kumarabhi006
Copy link
Contributor

@kumarabhi006 kumarabhi006 commented Sep 7, 2023

Few closed JList and JMenubar swing tests are open sourced.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315761: Open source few swing JList and JMenuBar tests (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15621/head:pull/15621
$ git checkout pull/15621

Update a local copy of the PR:
$ git checkout pull/15621
$ git pull https://git.openjdk.org/jdk.git pull/15621/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15621

View PR using the GUI difftool:
$ git pr show -t 15621

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15621.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 7, 2023

👋 Welcome back abhiscxk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 7, 2023
@openjdk
Copy link

openjdk bot commented Sep 7, 2023

@kumarabhi006 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 7, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 7, 2023

Webrevs

Copy link
Contributor

@prsadhuk prsadhuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment...Also please ensure mach5 job is run in open too before integration


public class bug4832765 {

static String[] data = {"One", "Two", "Three", "Four",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess data can be local var

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@openjdk
Copy link

openjdk bot commented Sep 8, 2023

@kumarabhi006 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315761: Open source few swing JList and JMenuBar tests

Reviewed-by: psadhukhan, tr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 101 new commits pushed to the master branch:

  • fda142f: 8312174: missing JVMTI events from vthreads parked during JVMTI attach
  • d0be73a: 8041488: Locale-Dependent List Patterns
  • dd214d0: 8315437: Enable parallelism in vmTestbase/nsk/monitoring/stress/classload tests
  • 877731d: 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies
  • d06a564: 8315765: G1: Incorrect use of G1LastPLABAverageOccupancy
  • 66b6a5a: 8277954: Replace use of monitors with explicit locks in the JDK LDAP provider implementation
  • 4cb4637: 8315970: Big-endian issues after JDK-8310929
  • ae08143: 8315611: Open source swing text/html and tree test
  • 7b3e697: 8315855: G1: Revise signature of set_humongous_candidate
  • 1941290: 8315942: Sort platform enums and definitions after JDK-8304913 follow-ups
  • ... and 91 more: https://git.openjdk.org/jdk/compare/75d4ac2659fb8748777458ceeea3d2e7087be40c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 8, 2023
@kumarabhi006
Copy link
Contributor Author

Minor comment...Also please ensure mach5 job is run in open too before integration

Ran the mach5 job in open too, it was green. Link added in JBS comment.

@kumarabhi006
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 13, 2023

Going to push as commit bb6b3f2.
Since your change was applied there have been 127 commits pushed to the master branch:

  • 2d168c5: 8313202: MutexLocker should disallow null Mutexes
  • 36552e7: 8316123: ProblemList serviceability/dcmd/gc/RunFinalizationTest.java on AIX
  • fe5ef5f: 8315677: Open source few swing JFileChooser and other tests
  • ece9bdf: 8299614: Shenandoah: STW mark should keep nmethod/oops referenced from stack chunk alive
  • a36f5a5: 8315663: Open source misc awt tests
  • cbbfa0d: 8315652: RISC-V: Features string uses wrong separator for jtreg
  • 1ebf510: 8315743: RISC-V: Cleanup masm lr()/sc() methods
  • bd52bbf: 8316060: test/hotspot/jtreg/runtime/reflect/ReflectOutOfMemoryError.java may fail if heap is huge
  • dde1155: 8315946: DecimalFormat and CompactNumberFormat do allow U+FFFE and U+FFFF in the pattern
  • a9679ac: 8253620: Debug symbols for tests missing on macos and windows
  • ... and 117 more: https://git.openjdk.org/jdk/compare/75d4ac2659fb8748777458ceeea3d2e7087be40c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 13, 2023
@openjdk openjdk bot closed this Sep 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 13, 2023
@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@kumarabhi006 Pushed as commit bb6b3f2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants