Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315677: Open source few swing JFileChooser and other tests #15626

Closed
wants to merge 2 commits into from

Conversation

kumarabhi006
Copy link
Contributor

@kumarabhi006 kumarabhi006 commented Sep 7, 2023

Few closed JFileChooser and other swing tests are open sourced.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315677: Open source few swing JFileChooser and other tests (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15626/head:pull/15626
$ git checkout pull/15626

Update a local copy of the PR:
$ git checkout pull/15626
$ git pull https://git.openjdk.org/jdk.git pull/15626/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15626

View PR using the GUI difftool:
$ git pr show -t 15626

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15626.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 7, 2023

👋 Welcome back abhiscxk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 7, 2023
@openjdk
Copy link

openjdk bot commented Sep 7, 2023

@kumarabhi006 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 7, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 7, 2023

Webrevs

Copy link
Contributor

@prsadhuk prsadhuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope you have run these tests in open in mach5 as mentioned, as I dont see any test run job result in JBS..Approving assumming you have run and no issues in test job..

@openjdk
Copy link

openjdk bot commented Sep 8, 2023

@kumarabhi006 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315677: Open source few swing JFileChooser and other tests

Reviewed-by: psadhukhan, tr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 110 new commits pushed to the master branch:

  • 347beb2: 8315998: Remove dead ClassLoaderDataGraphKlassIteratorStatic
  • 50158f3: 8316002: Remove unnecessary seen_dead_loader in ClassLoaderDataGraph::do_unloading
  • 6f2684b: 8315948: JDK-8315818 broke Xcomp on libgraal
  • 8b4f9a8: 8315990: Amend problemlisted tests to proper position
  • 455c471: 8313277: Resolve multiple definition of 'normalize' when statically linking JDK native libraries with user code
  • 3b422d0: 8316094: Problemlist compiler/rangechecks/TestRangeCheckHoistingScaledIV.java
  • f55e799: 8316038: Fix doc typos in java.io.Console and java.util.Scanner
  • 9480078: 8315550: G1: Fix -Wconversion warnings in g1NUMA
  • d08258f: 8315938: Deprecate for removal Unsafe methods that have standard APIs for many releases
  • fda142f: 8312174: missing JVMTI events from vthreads parked during JVMTI attach
  • ... and 100 more: https://git.openjdk.org/jdk/compare/75d4ac2659fb8748777458ceeea3d2e7087be40c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 8, 2023
@kumarabhi006
Copy link
Contributor Author

I hope you have run these tests in open in mach5 as mentioned, as I dont see any test run job result in JBS..Approving assumming you have run and no issues in test job..

I ran these tests in CI, it was green. Forgot to add in comment in JBS. Link added in JBS now.

fc.setControlButtonsAreShown(false);
fr.getContentPane().add(fc);
fr.pack();
fr.setVisible(true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delay might be required before starting test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't observe any failure for multiple runs without delay.


passAround(fc);
if (!passed) {
throw new RuntimeException("Test failed");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RuntimeException can be outside SwingUtility to avoid Invocation error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@kumarabhi006
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 13, 2023

Going to push as commit fe5ef5f.
Since your change was applied there have been 124 commits pushed to the master branch:

  • ece9bdf: 8299614: Shenandoah: STW mark should keep nmethod/oops referenced from stack chunk alive
  • a36f5a5: 8315663: Open source misc awt tests
  • cbbfa0d: 8315652: RISC-V: Features string uses wrong separator for jtreg
  • 1ebf510: 8315743: RISC-V: Cleanup masm lr()/sc() methods
  • bd52bbf: 8316060: test/hotspot/jtreg/runtime/reflect/ReflectOutOfMemoryError.java may fail if heap is huge
  • dde1155: 8315946: DecimalFormat and CompactNumberFormat do allow U+FFFE and U+FFFF in the pattern
  • a9679ac: 8253620: Debug symbols for tests missing on macos and windows
  • 020255a: 8267174: Many test files have the wrong Copyright header
  • ac2dfe4: 8313865: Always true condition in sun.nio.cs.CharsetMapping#readINDEXC2B
  • 947dee7: 8316113: Infinite permission checking loop in java/net/spi/InetAddressResolverProvider/RuntimePermissionTest
  • ... and 114 more: https://git.openjdk.org/jdk/compare/75d4ac2659fb8748777458ceeea3d2e7087be40c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 13, 2023
@openjdk openjdk bot closed this Sep 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 13, 2023
@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@kumarabhi006 Pushed as commit fe5ef5f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants