Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315882: Open some swing tests 2 #15628

Closed
wants to merge 4 commits into from

Conversation

alisenchung
Copy link
Contributor

@alisenchung alisenchung commented Sep 7, 2023

Opening some swing tests


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15628/head:pull/15628
$ git checkout pull/15628

Update a local copy of the PR:
$ git checkout pull/15628
$ git pull https://git.openjdk.org/jdk.git pull/15628/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15628

View PR using the GUI difftool:
$ git pr show -t 15628

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15628.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 7, 2023

👋 Welcome back achung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 7, 2023
@openjdk
Copy link

openjdk bot commented Sep 7, 2023

@alisenchung The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 7, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 7, 2023

Webrevs

JTextArea textArea;

public void init() {
fr = new JFrame("Test");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JFrame will be created on non-EDT.

@alisenchung alisenchung deleted the 2023_test_sprint_2 branch September 11, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org rfr Pull request is ready for review
2 participants