8238812: assert(false) failed: bad AD file #1563
Request help to review this 8238812 fix.
Found the root cause of the problem as that the following type
170 ConI === 0 [[ 171 ]] #int:31
173 If === 158 172 [[ 176 177 ]]
180 If === 177 179 [[ 181 182 ]]
Where 144 is the value and the ifs check for:
Now if we reach 182 IfFalse, the following holds:
But the type of value (144) becomes #int:16..31 :
And that means that value > 31 is always false and should be folded.
Found the IfNode::fold_compares optmization (and 8236721 related changes by Tobias)
Proposed changes helped to add the required If node to _worklist (after the correct type setting of related value)
/reviewer credit thartmann
The text was updated successfully, but these errors were encountered:
@r-v-raghav This change now passes all automated pre-integration checks.
After integration, the commit message for the final commit will be:
At the time when this comment was updated there had been 58 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
Please note suspending this PR review for now.
@r-v-raghav This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!