Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315898: Open source swing JMenu tests #15639

Closed
wants to merge 1 commit into from

Conversation

kumarabhi006
Copy link
Contributor

@kumarabhi006 kumarabhi006 commented Sep 8, 2023

Few closed JMenu swing tests are open sourced.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315898: Open source swing JMenu tests (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15639/head:pull/15639
$ git checkout pull/15639

Update a local copy of the PR:
$ git checkout pull/15639
$ git pull https://git.openjdk.org/jdk.git pull/15639/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15639

View PR using the GUI difftool:
$ git pr show -t 15639

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15639.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 8, 2023

👋 Welcome back abhiscxk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 8, 2023
@openjdk
Copy link

openjdk bot commented Sep 8, 2023

@kumarabhi006 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 8, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 8, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 10, 2023

@kumarabhi006 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315898: Open source swing JMenu tests

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 87 new commits pushed to the master branch:

  • 9a83d55: 8315373: Change VirtualThread to unmount after freezing, re-mount before thawing
  • 68f6941: 8314452: Explicitly indicate inlining success/failure in PrintInlining
  • b482e6d: 8315580: Remove unused java_lang_String::set_value_raw()
  • 9b0da48: 8315410: Undocumented exceptions in java.text.StringCharacterIterator
  • 578ded4: 8312418: Add Elements.getEnumConstantBody
  • dccf670: 8306632: Add a JDK Property for specifying DTD support
  • a62c48b: 8315891: java/foreign/TestLinker.java failed with "error occurred while instantiating class TestLinker: null"
  • 9559e03: 8315578: PPC builds are broken after JDK-8304913
  • e409d07: 8315696: SignedLoggerFinderTest.java test failed
  • ab6a87e: 8314838: 3 compiler tests ignore vm flags
  • ... and 77 more: https://git.openjdk.org/jdk/compare/75d4ac2659fb8748777458ceeea3d2e7087be40c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 10, 2023
@kumarabhi006
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 13, 2023

Going to push as commit fecd2fd.
Since your change was applied there have been 128 commits pushed to the master branch:

  • bb6b3f2: 8315761: Open source few swing JList and JMenuBar tests
  • 2d168c5: 8313202: MutexLocker should disallow null Mutexes
  • 36552e7: 8316123: ProblemList serviceability/dcmd/gc/RunFinalizationTest.java on AIX
  • fe5ef5f: 8315677: Open source few swing JFileChooser and other tests
  • ece9bdf: 8299614: Shenandoah: STW mark should keep nmethod/oops referenced from stack chunk alive
  • a36f5a5: 8315663: Open source misc awt tests
  • cbbfa0d: 8315652: RISC-V: Features string uses wrong separator for jtreg
  • 1ebf510: 8315743: RISC-V: Cleanup masm lr()/sc() methods
  • bd52bbf: 8316060: test/hotspot/jtreg/runtime/reflect/ReflectOutOfMemoryError.java may fail if heap is huge
  • dde1155: 8315946: DecimalFormat and CompactNumberFormat do allow U+FFFE and U+FFFF in the pattern
  • ... and 118 more: https://git.openjdk.org/jdk/compare/75d4ac2659fb8748777458ceeea3d2e7087be40c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 13, 2023
@openjdk openjdk bot closed this Sep 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 13, 2023
@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@kumarabhi006 Pushed as commit fecd2fd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants