Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256679: Update serialization javadoc once JOSS changes for records are complete #1564

Closed
wants to merge 4 commits into from

Conversation

FrauBoes
Copy link
Member

@FrauBoes FrauBoes commented Dec 2, 2020

Now that the changes for record serialization are integrated into the Java Object Serialization Specification, this change updates the serialization javadocs in ObjectInputStream, ObjectOutputStream, Serializable and java.lang.Record. Additionally, the suppression of preview related warnings is removed in ObjectOutputStream and ObjectStreamClass.

CSR: https://bugs.openjdk.java.net/browse/JDK-8257592


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8256679: Update serialization javadoc once JOSS changes for records are complete

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1564/head:pull/1564
$ git checkout pull/1564

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 2, 2020

👋 Welcome back jboes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 2, 2020
@openjdk
Copy link

openjdk bot commented Dec 2, 2020

@FrauBoes The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Dec 2, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 2, 2020

Webrevs

@FrauBoes
Copy link
Member Author

FrauBoes commented Dec 2, 2020

/csr needed

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Dec 2, 2020
@openjdk
Copy link

openjdk bot commented Dec 2, 2020

@FrauBoes this pull request will not be integrated until the CSR request JDK-8257592 for issue JDK-8256679 has been approved.

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Dec 4, 2020
@openjdk
Copy link

openjdk bot commented Dec 4, 2020

@FrauBoes This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8256679: Update serialization javadoc once JOSS changes for records are complete

Reviewed-by: chegar, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 86 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 4, 2020
@FrauBoes
Copy link
Member Author

FrauBoes commented Dec 7, 2020

/integrate

@openjdk openjdk bot closed this Dec 7, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 7, 2020
@openjdk
Copy link

openjdk bot commented Dec 7, 2020

@FrauBoes Since your change was applied there have been 95 commits pushed to the master branch:

  • 7620124: 8257230: assert(InitialHeapSize >= MinHeapSize) failed: Ergonomics decided on incompatible initial and minimum heap sizes
  • 05dac03: 8257803: Add -Xbatch to compiler/blackhole tests
  • 29a09c8: 8257668: SA JMap - skip non-java thread stack dump for heap dump
  • e590618: 8252505: C1/C2 compiler support for blackholes
  • 972bc3b: 8256167: Convert JDK use of Reference::get to Reference::refersTo
  • 78be334: 8242332: Add SHA3 support to SunPKCS11 provider
  • c4339c3: 8243614: Typo in ReentrantLock's Javadoc
  • d3ac1bf: 8198390: Test MultiResolutionDrawImageWithTransformTest.java fails when -esa is passed
  • 51d325e: 8257633: Missing -mmacosx-version-min=X flag when linking libjvm
  • e27ea4d: 8257750: writeBuffer field of java.io.DataOutputStream should be final
  • ... and 85 more: https://git.openjdk.java.net/jdk/compare/1433bafb33038e2c27fb166655f1352e85dc4b4d...master

Your commit was automatically rebased without conflicts.

Pushed as commit d05401d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@FrauBoes FrauBoes deleted the 8256679 branch Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants